c0ac25bfff
Readiness as no reasoning to be cluster scope because that is not how the k8s networking works for pods, all the pods to a deployment are not sharing the network in a singleton. Instead they are run as local scopes to themselves, with readiness failures the pod is potentially taken out of the network to be resolvable - this affects the distributed setup in myriad of different ways. Instead readiness should behave like liveness with local scope alone, and should be a dummy implementation. This PR all the startup times and overal k8s startup time dramatically improves. Added another handler called as `/minio/health/cluster` to understand the cluster scope health.
57 lines
1.7 KiB
Go
57 lines
1.7 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2018 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
)
|
|
|
|
// ClusterCheckHandler returns if the server is ready for requests.
|
|
func ClusterCheckHandler(w http.ResponseWriter, r *http.Request) {
|
|
ctx := newContext(r, w, "ClusterCheckCheckHandler")
|
|
|
|
objLayer := newObjectLayerFn()
|
|
// Service not initialized yet
|
|
if objLayer == nil {
|
|
writeResponse(w, http.StatusServiceUnavailable, nil, mimeNone)
|
|
return
|
|
}
|
|
|
|
ctx, cancel := context.WithTimeout(ctx, globalAPIConfig.getReadyDeadline())
|
|
defer cancel()
|
|
|
|
if !objLayer.IsReady(ctx) {
|
|
writeResponse(w, http.StatusServiceUnavailable, nil, mimeNone)
|
|
return
|
|
}
|
|
|
|
writeResponse(w, http.StatusOK, nil, mimeNone)
|
|
}
|
|
|
|
// ReadinessCheckHandler Checks if the process is up. Always returns success.
|
|
func ReadinessCheckHandler(w http.ResponseWriter, r *http.Request) {
|
|
// TODO: only implement this function to notify that this pod is
|
|
// busy, at a local scope in future, for now '200 OK'.
|
|
writeResponse(w, http.StatusOK, nil, mimeNone)
|
|
}
|
|
|
|
// LivenessCheckHandler - Checks if the process is up. Always returns success.
|
|
func LivenessCheckHandler(w http.ResponseWriter, r *http.Request) {
|
|
writeResponse(w, http.StatusOK, nil, mimeNone)
|
|
}
|