a536cf5dc0
It can happen with erroneous clients which do not send `Host:` header until 4k worth of header bytes have been read. This can lead to Peek() method of bufio to fail with ErrBufferFull. To avoid this we should make sure that Peek buffer is as large as our maxHeaderBytes count.
118 lines
2.8 KiB
Go
118 lines
2.8 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package http
|
|
|
|
import (
|
|
"bufio"
|
|
"io"
|
|
"net"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// Test bufconn handles read timeout properly by reading two messages beyond deadline.
|
|
func TestBuffConnReadTimeout(t *testing.T) {
|
|
l, err := net.Listen("tcp", "localhost:0")
|
|
if err != nil {
|
|
t.Fatalf("unable to create listener. %v", err)
|
|
}
|
|
defer l.Close()
|
|
serverAddr := l.Addr().String()
|
|
|
|
tcpListener, ok := l.(*net.TCPListener)
|
|
if !ok {
|
|
t.Fatalf("failed to assert to net.TCPListener")
|
|
}
|
|
|
|
var wg sync.WaitGroup
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
|
|
tcpConn, terr := tcpListener.AcceptTCP()
|
|
if terr != nil {
|
|
t.Errorf("failed to accept new connection. %v", terr)
|
|
return
|
|
}
|
|
bufconn := newBufConn(tcpConn, 1*time.Second, 1*time.Second, 4096)
|
|
defer bufconn.Close()
|
|
|
|
// Read a line
|
|
var b = make([]byte, 12)
|
|
_, terr = bufconn.Read(b)
|
|
if terr != nil {
|
|
t.Errorf("failed to read from client. %v", terr)
|
|
return
|
|
}
|
|
received := string(b)
|
|
if received != "message one\n" {
|
|
t.Errorf(`server: expected: "message one\n", got: %v`, received)
|
|
return
|
|
}
|
|
|
|
// Wait for more than read timeout to simulate processing.
|
|
time.Sleep(3 * time.Second)
|
|
|
|
_, terr = bufconn.Read(b)
|
|
if terr != nil {
|
|
t.Errorf("failed to read from client. %v", terr)
|
|
return
|
|
}
|
|
received = string(b)
|
|
if received != "message two\n" {
|
|
t.Errorf(`server: expected: "message two\n", got: %v`, received)
|
|
return
|
|
}
|
|
|
|
// Send a response.
|
|
_, terr = io.WriteString(bufconn, "messages received\n")
|
|
if terr != nil {
|
|
t.Errorf("failed to write to client. %v", terr)
|
|
return
|
|
}
|
|
|
|
// Removes all deadlines if any.
|
|
bufconn.RemoveTimeout()
|
|
}()
|
|
|
|
c, err := net.Dial("tcp", serverAddr)
|
|
if err != nil {
|
|
t.Fatalf("unable to connect to server. %v", err)
|
|
}
|
|
defer c.Close()
|
|
|
|
_, err = io.WriteString(c, "message one\n")
|
|
if err != nil {
|
|
t.Fatalf("failed to write to server. %v", err)
|
|
}
|
|
_, err = io.WriteString(c, "message two\n")
|
|
if err != nil {
|
|
t.Fatalf("failed to write to server. %v", err)
|
|
}
|
|
|
|
received, err := bufio.NewReader(c).ReadString('\n')
|
|
if err != nil {
|
|
t.Fatalf("failed to read from server. %v", err)
|
|
}
|
|
if received != "messages received\n" {
|
|
t.Fatalf(`client: expected: "messages received\n", got: %v`, received)
|
|
}
|
|
|
|
wg.Wait()
|
|
}
|