70d2cb5f4d
This removal comes to avoid some redundant requirements which are adding more problems on a production setup. Here are the list of checks for time as they happen - Fresh connect (during server startup) - CORRECT - A reconnect after network disconnect - CORRECT - For each RPC call - INCORRECT. Verifying time for each RPC aggravates a situation where a RPC call is rejected in a sequence of events due to enough load on a production setup. 3 second might not be enough time window for the call to be initiated and received by the server.
109 lines
2.9 KiB
Go
109 lines
2.9 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2014-2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"encoding/json"
|
|
"path"
|
|
"testing"
|
|
)
|
|
|
|
type TestRPCS3PeerSuite struct {
|
|
testServer TestServer
|
|
testAuthConf authConfig
|
|
disks []string
|
|
}
|
|
|
|
// Set up the suite and start the test server.
|
|
func (s *TestRPCS3PeerSuite) SetUpSuite(t *testing.T) {
|
|
s.testServer, s.disks = StartTestS3PeerRPCServer(t)
|
|
s.testAuthConf = authConfig{
|
|
serverAddr: s.testServer.Server.Listener.Addr().String(),
|
|
accessKey: s.testServer.AccessKey,
|
|
secretKey: s.testServer.SecretKey,
|
|
serviceEndpoint: path.Join(minioReservedBucketPath, s3Path),
|
|
serviceName: "S3",
|
|
}
|
|
}
|
|
|
|
func (s *TestRPCS3PeerSuite) TearDownSuite(t *testing.T) {
|
|
s.testServer.Stop()
|
|
removeRoots(s.disks)
|
|
removeAll(s.testServer.Root)
|
|
}
|
|
|
|
func TestS3PeerRPC(t *testing.T) {
|
|
// setup
|
|
s := &TestRPCS3PeerSuite{}
|
|
s.SetUpSuite(t)
|
|
|
|
// run test
|
|
s.testS3PeerRPC(t)
|
|
|
|
// teardown
|
|
s.TearDownSuite(t)
|
|
}
|
|
|
|
// Test S3 RPC handlers
|
|
func (s *TestRPCS3PeerSuite) testS3PeerRPC(t *testing.T) {
|
|
// Validate for invalid token.
|
|
args := AuthRPCArgs{AuthToken: "garbage"}
|
|
rclient := newRPCClient(s.testAuthConf.serverAddr, s.testAuthConf.serviceEndpoint, false)
|
|
defer rclient.Close()
|
|
err := rclient.Call("S3.SetBucketNotificationPeer", &args, &AuthRPCReply{})
|
|
if err != nil {
|
|
if err.Error() != errInvalidToken.Error() {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
// Check bucket notification call works.
|
|
BNPArgs := SetBucketNotificationPeerArgs{Bucket: "bucket", NCfg: ¬ificationConfig{}}
|
|
client := newAuthRPCClient(s.testAuthConf)
|
|
defer client.Close()
|
|
err = client.Call("S3.SetBucketNotificationPeer", &BNPArgs, &AuthRPCReply{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Check bucket listener update call works.
|
|
BLPArgs := SetBucketListenerPeerArgs{Bucket: "bucket", LCfg: nil}
|
|
err = client.Call("S3.SetBucketListenerPeer", &BLPArgs, &AuthRPCReply{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Check bucket policy update call works.
|
|
pCh := policyChange{IsRemove: true}
|
|
pChBytes, err := json.Marshal(pCh)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
BPPArgs := SetBucketPolicyPeerArgs{Bucket: "bucket", PChBytes: pChBytes}
|
|
err = client.Call("S3.SetBucketPolicyPeer", &BPPArgs, &AuthRPCReply{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Check event send event call works.
|
|
evArgs := EventArgs{Event: nil, Arn: "localhost:9000"}
|
|
err = client.Call("S3.Event", &evArgs, &AuthRPCReply{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|