dd6ecf1193
- Reads and writes of uploads.json in XL now uses quorum for newMultipart, completeMultipart and abortMultipart operations. - Each disk's `uploads.json` file is read and updated independently for adding or removing an upload id from the file. Quorum is used to decide if the high-level operation actually succeeded. - Refactor FS code to simplify the flow, and fix a bug while reading uploads.json.
91 lines
2.7 KiB
Go
91 lines
2.7 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import "path"
|
|
|
|
// Returns if the prefix is a multipart upload.
|
|
func (fs fsObjects) isMultipartUpload(bucket, prefix string) bool {
|
|
_, err := fs.storage.StatFile(bucket, pathJoin(prefix, uploadsJSONFile))
|
|
return err == nil
|
|
}
|
|
|
|
// Checks whether bucket exists.
|
|
func (fs fsObjects) isBucketExist(bucket string) bool {
|
|
// Check whether bucket exists.
|
|
_, err := fs.storage.StatVol(bucket)
|
|
if err != nil {
|
|
if err == errVolumeNotFound {
|
|
return false
|
|
}
|
|
errorIf(err, "Stat failed on bucket "+bucket+".")
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
// isUploadIDExists - verify if a given uploadID exists and is valid.
|
|
func (fs fsObjects) isUploadIDExists(bucket, object, uploadID string) bool {
|
|
uploadIDPath := path.Join(mpartMetaPrefix, bucket, object, uploadID)
|
|
_, err := fs.storage.StatFile(minioMetaBucket, path.Join(uploadIDPath, fsMetaJSONFile))
|
|
if err != nil {
|
|
if err == errFileNotFound {
|
|
return false
|
|
}
|
|
errorIf(err, "Unable to access upload id"+uploadIDPath)
|
|
return false
|
|
}
|
|
return true
|
|
}
|
|
|
|
// writeUploadJSON - create `uploads.json` or update it with new uploadID.
|
|
func (fs fsObjects) updateUploadJSON(bucket, object string, uCh uploadIDChange) error {
|
|
uploadsPath := path.Join(mpartMetaPrefix, bucket, object, uploadsJSONFile)
|
|
uniqueID := getUUID()
|
|
tmpUploadsPath := path.Join(tmpMetaPrefix, uniqueID)
|
|
|
|
uploadsJSON, err := readUploadsJSON(bucket, object, fs.storage)
|
|
if errorCause(err) == errFileNotFound {
|
|
// If file is not found, we assume a default (empty)
|
|
// upload info.
|
|
uploadsJSON, err = newUploadsV1("fs"), nil
|
|
}
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// update the uploadsJSON struct
|
|
if !uCh.isRemove {
|
|
// Add the uploadID
|
|
uploadsJSON.AddUploadID(uCh.uploadID, uCh.initiated)
|
|
} else {
|
|
// Remove the upload ID
|
|
uploadsJSON.RemoveUploadID(uCh.uploadID)
|
|
}
|
|
|
|
// update the file or delete it?
|
|
if len(uploadsJSON.Uploads) > 0 {
|
|
err = writeUploadJSON(&uploadsJSON, uploadsPath, tmpUploadsPath, fs.storage)
|
|
} else {
|
|
// no uploads, so we delete the file.
|
|
if err = fs.storage.DeleteFile(minioMetaBucket, uploadsPath); err != nil {
|
|
return toObjectErr(traceError(err), minioMetaBucket, uploadsPath)
|
|
}
|
|
}
|
|
return err
|
|
}
|