79ba4d3f33
This change refactor the ObjectLayer PutObject and PutObjectPart functions. Instead of passing an io.Reader and a size to PUT operations ObejectLayer expects an HashReader. A HashReader verifies the MD5 sum (and SHA256 sum if required) of the object. This change updates all all PutObject(Part) calls and removes unnecessary code in all ObjectLayer implementations. Fixes #4923
117 lines
3.4 KiB
Go
117 lines
3.4 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"bytes"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
// Tests ToObjectInfo function.
|
|
func TestFSV1MetadataObjInfo(t *testing.T) {
|
|
fsMeta := newFSMetaV1()
|
|
objInfo := fsMeta.ToObjectInfo("testbucket", "testobject", nil)
|
|
if objInfo.Size != 0 {
|
|
t.Fatal("Unexpected object info value for Size", objInfo.Size)
|
|
}
|
|
if objInfo.ModTime != timeSentinel {
|
|
t.Fatal("Unexpected object info value for ModTime ", objInfo.ModTime)
|
|
}
|
|
if objInfo.IsDir {
|
|
t.Fatal("Unexpected object info value for IsDir", objInfo.IsDir)
|
|
}
|
|
}
|
|
|
|
// TestReadFSMetadata - readFSMetadata testing with a healthy and faulty disk
|
|
func TestReadFSMetadata(t *testing.T) {
|
|
disk := filepath.Join(globalTestTmpDir, "minio-"+nextSuffix())
|
|
defer os.RemoveAll(disk)
|
|
|
|
obj := initFSObjects(disk, t)
|
|
fs := obj.(*fsObjects)
|
|
|
|
bucketName := "bucket"
|
|
objectName := "object"
|
|
|
|
if err := obj.MakeBucketWithLocation(bucketName, ""); err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
if _, err := obj.PutObject(bucketName, objectName, NewHashReader(bytes.NewReader([]byte("abcd")), int64(len("abcd")), "", ""), nil); err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
|
|
// Construct the full path of fs.json
|
|
fsPath := pathJoin(bucketMetaPrefix, bucketName, objectName, "fs.json")
|
|
fsPath = pathJoin(fs.fsPath, minioMetaBucket, fsPath)
|
|
|
|
rlk, err := fs.rwPool.Open(fsPath)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error ", err)
|
|
}
|
|
defer rlk.Close()
|
|
|
|
// Regular fs metadata reading, no errors expected
|
|
fsMeta := fsMetaV1{}
|
|
if _, err = fsMeta.ReadFrom(rlk.LockedFile); err != nil {
|
|
t.Fatal("Unexpected error ", err)
|
|
}
|
|
}
|
|
|
|
// TestWriteFSMetadata - tests of writeFSMetadata with healthy disk.
|
|
func TestWriteFSMetadata(t *testing.T) {
|
|
disk := filepath.Join(globalTestTmpDir, "minio-"+nextSuffix())
|
|
defer os.RemoveAll(disk)
|
|
|
|
obj := initFSObjects(disk, t)
|
|
fs := obj.(*fsObjects)
|
|
|
|
bucketName := "bucket"
|
|
objectName := "object"
|
|
|
|
if err := obj.MakeBucketWithLocation(bucketName, ""); err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
if _, err := obj.PutObject(bucketName, objectName, NewHashReader(bytes.NewReader([]byte("abcd")), int64(len("abcd")), "", ""), nil); err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
|
|
// Construct the full path of fs.json
|
|
fsPath := pathJoin(bucketMetaPrefix, bucketName, objectName, "fs.json")
|
|
fsPath = pathJoin(fs.fsPath, minioMetaBucket, fsPath)
|
|
|
|
rlk, err := fs.rwPool.Open(fsPath)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error ", err)
|
|
}
|
|
defer rlk.Close()
|
|
|
|
// FS metadata reading, no errors expected (healthy disk)
|
|
fsMeta := fsMetaV1{}
|
|
_, err = fsMeta.ReadFrom(rlk.LockedFile)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error ", err)
|
|
}
|
|
if fsMeta.Version != fsMetaVersion {
|
|
t.Fatalf("Unexpected version %s", fsMeta.Version)
|
|
}
|
|
if fsMeta.Format != fsMetaFormat {
|
|
t.Fatalf("Unexpected format %s", fsMeta.Format)
|
|
}
|
|
}
|