f8024cadbb
This is an improvement upon existing implementation by avoiding transfer of access and secret keys over the network. This change only exchanges JWT tokens generated by an rpc client. Even if the JWT can be traced over the network on a non-TLS connection, this change makes sure that we never really expose the secret key over the network.
136 lines
4 KiB
Go
136 lines
4 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016, 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"time"
|
|
|
|
jwtgo "github.com/dgrijalva/jwt-go"
|
|
jwtreq "github.com/dgrijalva/jwt-go/request"
|
|
)
|
|
|
|
const (
|
|
jwtAlgorithm = "Bearer"
|
|
|
|
// Default JWT token for web handlers is one day.
|
|
defaultJWTExpiry = 24 * time.Hour
|
|
|
|
// Inter-node JWT token expiry is 100 years approx.
|
|
defaultInterNodeJWTExpiry = 100 * 365 * 24 * time.Hour
|
|
|
|
// URL JWT token expiry is one minute (might be exposed).
|
|
defaultURLJWTExpiry = time.Minute
|
|
)
|
|
|
|
var (
|
|
errInvalidAccessKeyID = errors.New("The access key ID you provided does not exist in our records")
|
|
errChangeCredNotAllowed = errors.New("Changing access key and secret key not allowed")
|
|
errAuthentication = errors.New("Authentication failed, check your access credentials")
|
|
errNoAuthToken = errors.New("JWT token missing")
|
|
)
|
|
|
|
func authenticateJWT(accessKey, secretKey string, expiry time.Duration) (string, error) {
|
|
passedCredential, err := createCredential(accessKey, secretKey)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
serverCred := serverConfig.GetCredential()
|
|
|
|
if serverCred.AccessKey != passedCredential.AccessKey {
|
|
return "", errInvalidAccessKeyID
|
|
}
|
|
|
|
if !serverCred.Equal(passedCredential) {
|
|
return "", errAuthentication
|
|
}
|
|
|
|
utcNow := UTCNow()
|
|
token := jwtgo.NewWithClaims(jwtgo.SigningMethodHS512, jwtgo.StandardClaims{
|
|
ExpiresAt: utcNow.Add(expiry).Unix(),
|
|
IssuedAt: utcNow.Unix(),
|
|
Subject: accessKey,
|
|
})
|
|
|
|
return token.SignedString([]byte(serverCred.SecretKey))
|
|
}
|
|
|
|
func authenticateNode(accessKey, secretKey string) (string, error) {
|
|
return authenticateJWT(accessKey, secretKey, defaultInterNodeJWTExpiry)
|
|
}
|
|
|
|
func authenticateWeb(accessKey, secretKey string) (string, error) {
|
|
return authenticateJWT(accessKey, secretKey, defaultJWTExpiry)
|
|
}
|
|
|
|
func authenticateURL(accessKey, secretKey string) (string, error) {
|
|
return authenticateJWT(accessKey, secretKey, defaultURLJWTExpiry)
|
|
}
|
|
|
|
func keyFuncCallback(jwtToken *jwtgo.Token) (interface{}, error) {
|
|
if _, ok := jwtToken.Method.(*jwtgo.SigningMethodHMAC); !ok {
|
|
return nil, fmt.Errorf("Unexpected signing method: %v", jwtToken.Header["alg"])
|
|
}
|
|
|
|
return []byte(serverConfig.GetCredential().SecretKey), nil
|
|
}
|
|
|
|
func isAuthTokenValid(tokenString string) bool {
|
|
var claims jwtgo.StandardClaims
|
|
jwtToken, err := jwtgo.ParseWithClaims(tokenString, &claims, keyFuncCallback)
|
|
if err != nil {
|
|
errorIf(err, "Unable to parse JWT token string")
|
|
return false
|
|
}
|
|
if err = claims.Valid(); err != nil {
|
|
errorIf(err, "Invalid claims in JWT token string")
|
|
return false
|
|
}
|
|
return jwtToken.Valid && claims.Subject == serverConfig.GetCredential().AccessKey
|
|
}
|
|
|
|
func isHTTPRequestValid(req *http.Request) bool {
|
|
return webRequestAuthenticate(req) == nil
|
|
}
|
|
|
|
// Check if the request is authenticated.
|
|
// Returns nil if the request is authenticated. errNoAuthToken if token missing.
|
|
// Returns errAuthentication for all other errors.
|
|
func webRequestAuthenticate(req *http.Request) error {
|
|
var claims jwtgo.StandardClaims
|
|
jwtToken, err := jwtreq.ParseFromRequestWithClaims(req, jwtreq.AuthorizationHeaderExtractor, &claims, keyFuncCallback)
|
|
if err != nil {
|
|
if err == jwtreq.ErrNoTokenInRequest {
|
|
return errNoAuthToken
|
|
}
|
|
return errAuthentication
|
|
}
|
|
if err = claims.Valid(); err != nil {
|
|
return err
|
|
}
|
|
if claims.Subject != serverConfig.GetCredential().AccessKey {
|
|
return errInvalidAccessKeyID
|
|
}
|
|
if !jwtToken.Valid {
|
|
return errAuthentication
|
|
}
|
|
return nil
|
|
}
|