9fb94e6aa8
This commit adds a check to the server's admin-API such that it only accepts Admin-API requests with authenticated bodies. Further this commit updates the `madmin` package to always add the `X-Amz-Content-Sha256` header. This change improves the Admin-API security since the server does not accept unauthenticated request bodies anymore. After this commit `mc` must be updated to the new `madmin` api because requests over TLS connections will fail.
66 lines
1.7 KiB
Go
66 lines
1.7 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016, 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*
|
|
*/
|
|
|
|
package madmin
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
)
|
|
|
|
// SetCredsReq - xml to send to the server to set new credentials
|
|
type SetCredsReq struct {
|
|
AccessKey string `json:"accessKey"`
|
|
SecretKey string `json:"secretKey"`
|
|
}
|
|
|
|
// SetCredentials - Call Set Credentials API to set new access and
|
|
// secret keys in the specified Minio server
|
|
func (adm *AdminClient) SetCredentials(access, secret string) error {
|
|
// Setup request's body
|
|
body, err := json.Marshal(SetCredsReq{access, secret})
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// No TLS?
|
|
if !adm.secure {
|
|
return fmt.Errorf("credentials cannot be updated over an insecure connection")
|
|
}
|
|
|
|
// Setup new request
|
|
reqData := requestData{
|
|
relPath: "/v1/config/credential",
|
|
content: body,
|
|
}
|
|
|
|
// Execute GET on bucket to list objects.
|
|
resp, err := adm.executeMethod("PUT", reqData)
|
|
|
|
defer closeResponse(resp)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Return error to the caller if http response code is
|
|
// different from 200
|
|
if resp.StatusCode != http.StatusOK {
|
|
return httpRespToErrorResponse(resp)
|
|
}
|
|
return nil
|
|
}
|