7765081db7
Previous value was set to avoid large cache value build up but we can clearly see this can cause lots of GC pauses which can lead to significant drop in performance. Change this value to 50% and decrease the value to 25% once the 75% cache size is used. To have a larger window for GC pauses. Another change is to only allow caching if a server has more than 24GB of RAM instead of 8GB.
44 lines
1.4 KiB
Go
44 lines
1.4 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2017 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import "testing"
|
|
|
|
func TestGetMaxCacheSize(t *testing.T) {
|
|
testCases := []struct {
|
|
curLimit uint64
|
|
totalRAM uint64
|
|
expectedResult uint64
|
|
}{
|
|
{uint64(0), uint64(0), uint64(0)},
|
|
{minRAMSize, uint64(0), uint64(0)},
|
|
{uint64(0), minRAMSize, uint64(0)},
|
|
{uint64(18446744073709551615), uint64(8115998720), uint64(0)},
|
|
{uint64(8115998720), uint64(16115998720), uint64(0)},
|
|
{minRAMSize, minRAMSize, uint64(12884901888)},
|
|
{minRAMSize, uint64(16115998720), uint64(0)},
|
|
{uint64(18446744073709551615), uint64(10115998720), uint64(0)},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
cacheSize := getMaxCacheSize(testCase.curLimit, testCase.totalRAM)
|
|
if testCase.expectedResult != cacheSize {
|
|
t.Fatalf("Test %d, Expected: %v, Got: %v", i+1, testCase.expectedResult, cacheSize)
|
|
}
|
|
}
|
|
}
|