Ref #3229 After review with @abperiasamy we decided to remove all the unnecessary options - MINIO_BROWSER (Implemented as a security feature but now deemed obsolete since even if blocking access to MINIO_BROWSER, s3 API port is open) - MINIO_CACHE_EXPIRY (Defaults to 72h) - MINIO_MAXCONN (No one used this option and we don't test this) - MINIO_ENABLE_FSMETA (Enable FSMETA all the time) Remove --ignore-disks option - this option was implemented when XL layer would initialize the backend disks and heal them automatically to disallow XL accidentally using the root partition itself this option was introduced. This behavior has been changed XL no longer automatically initializes `format.json` a HEAL is controlled activity, so ignore-disks is not useful anymore. This change also addresses the problems of our documentation going forward and keeps things simple. This patch brings in reduction of options and defaulting them to a valid known inputs. This patch also serves as a guideline of limiting many ways to do the same thing.
194 lines
5.1 KiB
Go
194 lines
5.1 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/minio/minio/pkg/disk"
|
|
)
|
|
|
|
// TestStorageInfo - tests storage info.
|
|
func TestStorageInfo(t *testing.T) {
|
|
objLayer, fsDirs, err := prepareXL()
|
|
if err != nil {
|
|
t.Fatalf("Unable to initialize 'XL' object layer.")
|
|
}
|
|
|
|
// Remove all dirs.
|
|
for _, dir := range fsDirs {
|
|
defer removeAll(dir)
|
|
}
|
|
|
|
// Get storage info first attempt.
|
|
disks16Info := objLayer.StorageInfo()
|
|
|
|
// This test assumes homogenity between all disks,
|
|
// i.e if we loose one disk the effective storage
|
|
// usage values is assumed to decrease. If we have
|
|
// heterogenous environment this is not true all the time.
|
|
if disks16Info.Free <= 0 {
|
|
t.Fatalf("Diskinfo total free values should be greater 0")
|
|
}
|
|
if disks16Info.Total <= 0 {
|
|
t.Fatalf("Diskinfo total values should be greater 0")
|
|
}
|
|
|
|
endpoints, err := parseStorageEndpoints(fsDirs)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error %s", err)
|
|
}
|
|
|
|
storageDisks, err := initStorageDisks(endpoints)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error: ", err)
|
|
}
|
|
|
|
objLayer, err = newXLObjects(storageDisks)
|
|
if err != nil {
|
|
t.Fatalf("Unable to initialize 'XL' object layer with ignored disks %s. error %s", fsDirs[:4], err)
|
|
}
|
|
|
|
// Get storage info first attempt.
|
|
disks16Info = objLayer.StorageInfo()
|
|
|
|
// This test assumes homogenity between all disks,
|
|
// i.e if we loose one disk the effective storage
|
|
// usage values is assumed to decrease. If we have
|
|
// heterogenous environment this is not true all the time.
|
|
if disks16Info.Free <= 0 {
|
|
t.Fatalf("Diskinfo total free values should be greater 0")
|
|
}
|
|
if disks16Info.Total <= 0 {
|
|
t.Fatalf("Diskinfo total values should be greater 0")
|
|
}
|
|
}
|
|
|
|
// Sort valid disks info.
|
|
func TestSortingValidDisks(t *testing.T) {
|
|
testCases := []struct {
|
|
disksInfo []disk.Info
|
|
validDisksInfo []disk.Info
|
|
}{
|
|
// One of the disks is offline.
|
|
{
|
|
disksInfo: []disk.Info{
|
|
{Total: 150, Free: 10},
|
|
{Total: 0, Free: 0},
|
|
{Total: 200, Free: 10},
|
|
{Total: 100, Free: 10},
|
|
},
|
|
validDisksInfo: []disk.Info{
|
|
{Total: 100, Free: 10},
|
|
{Total: 150, Free: 10},
|
|
{Total: 200, Free: 10},
|
|
},
|
|
},
|
|
// All disks are online.
|
|
{
|
|
disksInfo: []disk.Info{
|
|
{Total: 150, Free: 10},
|
|
{Total: 200, Free: 10},
|
|
{Total: 100, Free: 10},
|
|
{Total: 115, Free: 10},
|
|
},
|
|
validDisksInfo: []disk.Info{
|
|
{Total: 100, Free: 10},
|
|
{Total: 115, Free: 10},
|
|
{Total: 150, Free: 10},
|
|
{Total: 200, Free: 10},
|
|
},
|
|
},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
validDisksInfo := sortValidDisksInfo(testCase.disksInfo)
|
|
if !reflect.DeepEqual(validDisksInfo, testCase.validDisksInfo) {
|
|
t.Errorf("Test %d: Expected %#v, Got %#v", i+1, testCase.validDisksInfo, validDisksInfo)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestNewXL - tests initialization of all input disks
|
|
// and constructs a valid `XL` object
|
|
func TestNewXL(t *testing.T) {
|
|
var nDisks = 16 // Maximum disks.
|
|
var erasureDisks []string
|
|
for i := 0; i < nDisks; i++ {
|
|
// Do not attempt to create this path, the test validates
|
|
// so that newFSObjects initializes non existing paths
|
|
// and successfully returns initialized object layer.
|
|
disk := filepath.Join(os.TempDir(), "minio-"+nextSuffix())
|
|
erasureDisks = append(erasureDisks, disk)
|
|
defer removeAll(disk)
|
|
}
|
|
|
|
// No disks input.
|
|
_, err := newXLObjects(nil)
|
|
if err != errInvalidArgument {
|
|
t.Fatalf("Unable to initialize erasure, %s", err)
|
|
}
|
|
|
|
endpoints, err := parseStorageEndpoints(erasureDisks)
|
|
if err != nil {
|
|
t.Fatalf("Unable to initialize erasure, %s", err)
|
|
}
|
|
|
|
storageDisks, err := initStorageDisks(endpoints)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error: ", err)
|
|
}
|
|
|
|
err = waitForFormatDisks(true, endpoints, nil)
|
|
if err != errInvalidArgument {
|
|
t.Fatalf("Expecting error, got %s", err)
|
|
}
|
|
|
|
err = waitForFormatDisks(true, nil, storageDisks)
|
|
if err != errInvalidArgument {
|
|
t.Fatalf("Expecting error, got %s", err)
|
|
}
|
|
|
|
// Initializes all erasure disks
|
|
err = waitForFormatDisks(true, endpoints, storageDisks)
|
|
if err != nil {
|
|
t.Fatalf("Unable to format disks for erasure, %s", err)
|
|
}
|
|
_, err = newXLObjects(storageDisks)
|
|
if err != nil {
|
|
t.Fatalf("Unable to initialize erasure, %s", err)
|
|
}
|
|
|
|
endpoints, err = parseStorageEndpoints(erasureDisks)
|
|
if err != nil {
|
|
t.Fatalf("Unable to initialize erasure, %s", err)
|
|
}
|
|
|
|
storageDisks, err = initStorageDisks(endpoints)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error: ", err)
|
|
}
|
|
|
|
// Initializes all erasure disks, ignoring first two.
|
|
_, err = newXLObjects(storageDisks)
|
|
if err != nil {
|
|
t.Fatalf("Unable to initialize erasure, %s", err)
|
|
}
|
|
}
|