When servers are started simultaneously across multiple nodes or simulating a local setup, it can happen such that one of the servers in setup reaches a following situation where it observes - Some servers are formatted - Some servers are unformatted - Some servers are offline Current state machine doesn't handle this correctly, to fix this situation where we have unformatted, formatted and disks offline we do not decisively know the course of action. So we wait for the offline disks to change their state. Once the offline disks change their state to either one of these states we can decisively move forward. - nil (formatted disk) - errUnformattedDisk - Or any other error such as errCorruptedDisk. Fixes #4903
160 lines
5.1 KiB
Go
160 lines
5.1 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import "testing"
|
|
|
|
func (action InitActions) String() string {
|
|
switch action {
|
|
case InitObjectLayer:
|
|
return "InitObjectLayer"
|
|
case FormatDisks:
|
|
return "FormatDisks"
|
|
case WaitForFormatting:
|
|
return "WaitForFormatting"
|
|
case SuggestToHeal:
|
|
return "SuggestToHeal"
|
|
case WaitForAll:
|
|
return "WaitForAll"
|
|
case WaitForQuorum:
|
|
return "WaitForQuorum"
|
|
case WaitForConfig:
|
|
return "WaitForConfig"
|
|
case Abort:
|
|
return "Abort"
|
|
default:
|
|
return "Unknown"
|
|
}
|
|
}
|
|
|
|
func TestPrepForInitXL(t *testing.T) {
|
|
// All disks are unformatted, a fresh setup.
|
|
allUnformatted := []error{
|
|
errUnformattedDisk, errUnformattedDisk, errUnformattedDisk, errUnformattedDisk,
|
|
errUnformattedDisk, errUnformattedDisk, errUnformattedDisk, errUnformattedDisk,
|
|
}
|
|
// All disks are formatted, possible restart of a node in a formatted setup.
|
|
allFormatted := []error{
|
|
nil, nil, nil, nil,
|
|
nil, nil, nil, nil,
|
|
}
|
|
// Quorum number of disks are formatted and rest are offline.
|
|
quorumFormatted := []error{
|
|
nil, nil, nil, nil,
|
|
nil, errDiskNotFound, errDiskNotFound, errDiskNotFound,
|
|
}
|
|
// Minority disks are corrupted, can be healed.
|
|
minorityCorrupted := []error{
|
|
errCorruptedFormat, errCorruptedFormat, errCorruptedFormat, nil,
|
|
nil, nil, nil, nil,
|
|
}
|
|
// Majority disks are corrupted, pretty bad setup.
|
|
majorityCorrupted := []error{
|
|
errCorruptedFormat, errCorruptedFormat, errCorruptedFormat, errCorruptedFormat,
|
|
errCorruptedFormat, nil, nil, nil,
|
|
}
|
|
// Quorum disks are unformatted, remaining yet to come online.
|
|
quorumUnformatted := []error{
|
|
errUnformattedDisk, errUnformattedDisk, errUnformattedDisk, errUnformattedDisk,
|
|
errUnformattedDisk, errDiskNotFound, errDiskNotFound, errDiskNotFound,
|
|
}
|
|
quorumUnformattedSomeCorrupted := []error{
|
|
errUnformattedDisk, errUnformattedDisk, errUnformattedDisk, errUnformattedDisk,
|
|
errUnformattedDisk, errCorruptedFormat, errCorruptedFormat, errDiskNotFound,
|
|
}
|
|
|
|
// Quorum number of disks not online yet.
|
|
noQuourm := []error{
|
|
errDiskNotFound, errDiskNotFound, errDiskNotFound, errDiskNotFound,
|
|
errDiskNotFound, nil, nil, nil,
|
|
}
|
|
// Invalid access key id.
|
|
accessKeyIDErr := []error{
|
|
errInvalidAccessKeyID, nil, nil, nil,
|
|
nil, nil, nil, nil,
|
|
}
|
|
// Authentication error.
|
|
authenticationErr := []error{
|
|
nil, nil, nil, nil,
|
|
errAuthentication, nil, nil, nil,
|
|
}
|
|
// Server version mismatch.
|
|
serverVersionMismatch := []error{
|
|
errServerVersionMismatch, nil, nil, nil,
|
|
errServerVersionMismatch, nil, nil, nil,
|
|
}
|
|
// Server time mismatch.
|
|
serverTimeMismatch := []error{
|
|
nil, nil, nil, nil,
|
|
errServerTimeMismatch, nil, nil, nil,
|
|
}
|
|
// Suggest to heal under formatted disks in quorum.
|
|
formattedDisksInQuorum := []error{
|
|
nil, nil, nil, nil,
|
|
errUnformattedDisk, errUnformattedDisk, errDiskNotFound, errDiskNotFound,
|
|
}
|
|
// Wait for all under undecisive state.
|
|
undecisiveErrs1 := []error{
|
|
errDiskNotFound, nil, nil, nil,
|
|
errUnformattedDisk, errUnformattedDisk, errDiskNotFound, errDiskNotFound,
|
|
}
|
|
undecisiveErrs2 := []error{
|
|
errDiskNotFound, errDiskNotFound, errDiskNotFound, errDiskNotFound,
|
|
errUnformattedDisk, errUnformattedDisk, errUnformattedDisk, errUnformattedDisk,
|
|
}
|
|
|
|
testCases := []struct {
|
|
// Params for prepForInit().
|
|
firstDisk bool
|
|
errs []error
|
|
diskCount int
|
|
action InitActions
|
|
}{
|
|
// Local disks.
|
|
{true, allFormatted, 8, InitObjectLayer},
|
|
{true, quorumFormatted, 8, InitObjectLayer},
|
|
{true, allUnformatted, 8, FormatDisks},
|
|
{true, quorumUnformatted, 8, WaitForAll},
|
|
{true, quorumUnformattedSomeCorrupted, 8, Abort},
|
|
{true, noQuourm, 8, WaitForQuorum},
|
|
{true, minorityCorrupted, 8, SuggestToHeal},
|
|
{true, majorityCorrupted, 8, Abort},
|
|
// Remote disks.
|
|
{false, allFormatted, 8, InitObjectLayer},
|
|
{false, quorumFormatted, 8, InitObjectLayer},
|
|
{false, allUnformatted, 8, WaitForFormatting},
|
|
{false, quorumUnformatted, 8, WaitForAll},
|
|
{false, quorumUnformattedSomeCorrupted, 8, Abort},
|
|
{false, noQuourm, 8, WaitForQuorum},
|
|
{false, minorityCorrupted, 8, SuggestToHeal},
|
|
{false, formattedDisksInQuorum, 8, SuggestToHeal},
|
|
{false, majorityCorrupted, 8, Abort},
|
|
{false, undecisiveErrs1, 8, WaitForAll},
|
|
{false, undecisiveErrs2, 8, WaitForAll},
|
|
// Config mistakes.
|
|
{true, accessKeyIDErr, 8, WaitForConfig},
|
|
{true, authenticationErr, 8, WaitForConfig},
|
|
{true, serverVersionMismatch, 8, WaitForConfig},
|
|
{true, serverTimeMismatch, 8, WaitForConfig},
|
|
}
|
|
for i, test := range testCases {
|
|
actual := prepForInitXL(test.firstDisk, test.errs, test.diskCount)
|
|
if actual != test.action {
|
|
t.Errorf("Test %d expected %s but received %s\n", i+1, test.action, actual)
|
|
}
|
|
}
|
|
}
|