3ca6330661
For objects with `N` prefix depth, this PR reduces `N` such network operations by converting `CheckFile` into a single bulk operation. Reduction in chattiness here would allow disks to be utilized more cleanly, while maintaining the same functionality along with one extra volume check stat() call is removed. Update tests to test multiple sets scenario
83 lines
2.2 KiB
Go
83 lines
2.2 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2017 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
// Tests for if parent directory is object
|
|
func TestErasureParentDirIsObject(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
obj, fsDisks, err := prepareErasureSets32(ctx)
|
|
if err != nil {
|
|
t.Fatalf("Unable to initialize 'Erasure' object layer.")
|
|
}
|
|
defer obj.Shutdown(context.Background())
|
|
|
|
// Remove all disks.
|
|
for _, disk := range fsDisks {
|
|
defer os.RemoveAll(disk)
|
|
}
|
|
|
|
bucketName := "testbucket"
|
|
objectName := "object"
|
|
|
|
if err = obj.MakeBucketWithLocation(GlobalContext, bucketName, BucketOptions{}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
objectContent := "12345"
|
|
_, err = obj.PutObject(GlobalContext, bucketName, objectName,
|
|
mustGetPutObjReader(t, bytes.NewReader([]byte(objectContent)), int64(len(objectContent)), "", ""), ObjectOptions{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
testCases := []struct {
|
|
expectedErr bool
|
|
objectName string
|
|
}{
|
|
{
|
|
expectedErr: true,
|
|
objectName: pathJoin(objectName, "parent-is-object"),
|
|
},
|
|
{
|
|
expectedErr: false,
|
|
objectName: pathJoin("no-parent", "object"),
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run("", func(t *testing.T) {
|
|
_, err = obj.PutObject(GlobalContext, bucketName, testCase.objectName,
|
|
mustGetPutObjReader(t, bytes.NewReader([]byte(objectContent)), int64(len(objectContent)), "", ""), ObjectOptions{})
|
|
if testCase.expectedErr && err == nil {
|
|
t.Error("Expected error but got nil")
|
|
}
|
|
if !testCase.expectedErr && err != nil {
|
|
t.Errorf("Expected nil but got %v", err)
|
|
}
|
|
})
|
|
}
|
|
}
|