This is an enhancement to the XL/distributed-XL mode. FS mode is unaffected. The ReadFileWithVerify storage-layer call is similar to ReadFile with the additional functionality of performing bit-rot checking. It accepts additional parameters for a hashing algorithm to use and the expected hex-encoded hash string. This patch provides significant performance improvement because: 1. combines the step of reading the file (during erasure-decoding/reconstruction) with bit-rot verification; 2. limits the number of file-reads; and 3. avoids transferring the file over the network for bit-rot verification. ReadFile API is implemented as ReadFileWithVerify with empty hashing arguments. Credits to AB and Harsha for the algorithmic improvement. Fixes #4236.
50 lines
1.7 KiB
Go
50 lines
1.7 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import "github.com/minio/minio/pkg/disk"
|
|
|
|
// StorageAPI interface.
|
|
type StorageAPI interface {
|
|
// Stringified version of disk.
|
|
String() string
|
|
|
|
// Storage operations.
|
|
Init() (err error)
|
|
Close() (err error)
|
|
DiskInfo() (info disk.Info, err error)
|
|
|
|
// Volume operations.
|
|
MakeVol(volume string) (err error)
|
|
ListVols() (vols []VolInfo, err error)
|
|
StatVol(volume string) (vol VolInfo, err error)
|
|
DeleteVol(volume string) (err error)
|
|
|
|
// File operations.
|
|
ListDir(volume, dirPath string) ([]string, error)
|
|
ReadFile(volume string, path string, offset int64, buf []byte) (n int64, err error)
|
|
ReadFileWithVerify(volume string, path string, offset int64, buf []byte,
|
|
algo HashAlgo, expectedHash string) (n int64, err error)
|
|
PrepareFile(volume string, path string, len int64) (err error)
|
|
AppendFile(volume string, path string, buf []byte) (err error)
|
|
RenameFile(srcVolume, srcPath, dstVolume, dstPath string) error
|
|
StatFile(volume string, path string) (file FileInfo, err error)
|
|
DeleteFile(volume string, path string) (err error)
|
|
|
|
// Read all.
|
|
ReadAll(volume string, path string) (buf []byte, err error)
|
|
}
|