20378821cf
httpRespToErrorResponse() usually reads the http response when the http error code is not expected to parse the json error response in the http body, however it was never properly closing the connection. This PR fixes the behavior.
88 lines
2.3 KiB
Go
88 lines
2.3 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package madmin
|
|
|
|
import (
|
|
"encoding/xml"
|
|
"net/http"
|
|
)
|
|
|
|
/* **** SAMPLE ERROR RESPONSE ****
|
|
<?xml version="1.0" encoding="UTF-8"?>
|
|
<Error>
|
|
<Code>AccessDenied</Code>
|
|
<Message>Access Denied</Message>
|
|
<BucketName>bucketName</BucketName>
|
|
<Key>objectName</Key>
|
|
<RequestId>F19772218238A85A</RequestId>
|
|
<HostId>GuWkjyviSiGHizehqpmsD1ndz5NClSP19DOT+s2mv7gXGQ8/X1lhbDGiIJEXpGFD</HostId>
|
|
</Error>
|
|
*/
|
|
|
|
// ErrorResponse - Is the typed error returned by all API operations.
|
|
type ErrorResponse struct {
|
|
XMLName xml.Name `xml:"Error" json:"-"`
|
|
Code string
|
|
Message string
|
|
BucketName string
|
|
Key string
|
|
RequestID string `xml:"RequestId"`
|
|
HostID string `xml:"HostId"`
|
|
|
|
// Region where the bucket is located. This header is returned
|
|
// only in HEAD bucket and ListObjects response.
|
|
Region string
|
|
}
|
|
|
|
// Error - Returns HTTP error string
|
|
func (e ErrorResponse) Error() string {
|
|
return e.Message
|
|
}
|
|
|
|
const (
|
|
reportIssue = "Please report this issue at https://github.com/minio/minio/issues."
|
|
)
|
|
|
|
// httpRespToErrorResponse returns a new encoded ErrorResponse
|
|
// structure as error.
|
|
func httpRespToErrorResponse(resp *http.Response) error {
|
|
if resp == nil {
|
|
msg := "Response is empty. " + reportIssue
|
|
return ErrInvalidArgument(msg)
|
|
}
|
|
var errResp ErrorResponse
|
|
// Decode the json error
|
|
err := jsonDecoder(resp.Body, &errResp)
|
|
if err != nil {
|
|
return ErrorResponse{
|
|
Code: resp.Status,
|
|
Message: "Failed to parse server response.",
|
|
}
|
|
}
|
|
closeResponse(resp)
|
|
return errResp
|
|
}
|
|
|
|
// ErrInvalidArgument - Invalid argument response.
|
|
func ErrInvalidArgument(message string) error {
|
|
return ErrorResponse{
|
|
Code: "InvalidArgument",
|
|
Message: message,
|
|
RequestID: "minio",
|
|
}
|
|
}
|