d864e00e24
Since go1.8 os.RemoveAll and os.MkdirAll both support long path names i.e UNC path on windows. The code we are carrying was directly borrowed from `pkg/os` package and doesn't need to be in our repo anymore. As a side affect this also addresses our codecoverage issue. Refer #4658
107 lines
2.7 KiB
Go
107 lines
2.7 KiB
Go
// +build windows
|
|
|
|
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"bytes"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
// Test if various paths work as expected when converted to UNC form
|
|
func TestUNCPaths(t *testing.T) {
|
|
var testCases = []struct {
|
|
objName string
|
|
pass bool
|
|
}{
|
|
{"/abcdef", true},
|
|
{"/a/b/c/d/e/f/g", true},
|
|
{string(bytes.Repeat([]byte("界"), 85)), true},
|
|
// Each path component must be <= 255 bytes long.
|
|
{string(bytes.Repeat([]byte("界"), 100)), false},
|
|
{`/p/q/r/s/t`, true},
|
|
}
|
|
// Instantiate posix object to manage a disk
|
|
var err error
|
|
err = os.Mkdir("c:\\testdisk", 0700)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Cleanup on exit of test
|
|
defer os.RemoveAll("c:\\testdisk")
|
|
|
|
var fs StorageAPI
|
|
fs, err = newPosix(`c:\testdisk`)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create volume to use in conjunction with other StorageAPI's file API(s)
|
|
err = fs.MakeVol("voldir")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
for _, test := range testCases {
|
|
err = fs.AppendFile("voldir", test.objName, []byte("hello"))
|
|
if err != nil && test.pass {
|
|
t.Error(err)
|
|
} else if err == nil && !test.pass {
|
|
t.Error(err)
|
|
}
|
|
fs.DeleteFile("voldir", test.objName)
|
|
}
|
|
}
|
|
|
|
// Test to validate posix behaviour on windows when a non-final path component is a file.
|
|
func TestUNCPathENOTDIR(t *testing.T) {
|
|
var err error
|
|
// Instantiate posix object to manage a disk
|
|
err = os.Mkdir("c:\\testdisk", 0700)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Cleanup on exit of test
|
|
defer os.RemoveAll("c:\\testdisk")
|
|
|
|
var fs StorageAPI
|
|
fs, err = newPosix(`c:\testdisk`)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Create volume to use in conjunction with other StorageAPI's file API(s)
|
|
err = fs.MakeVol("voldir")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
err = fs.AppendFile("voldir", "/file", []byte("hello"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// Try to create a file that includes a file in its path components.
|
|
// In *nix, this returns syscall.ENOTDIR while in windows we receive the following error.
|
|
err = fs.AppendFile("voldir", "/file/obj1", []byte("hello"))
|
|
if err != errFileAccessDenied {
|
|
t.Errorf("expected: %s, got: %s", errFileAccessDenied, err)
|
|
}
|
|
}
|