716316f711
Ref #3229 After review with @abperiasamy we decided to remove all the unnecessary options - MINIO_BROWSER (Implemented as a security feature but now deemed obsolete since even if blocking access to MINIO_BROWSER, s3 API port is open) - MINIO_CACHE_EXPIRY (Defaults to 72h) - MINIO_MAXCONN (No one used this option and we don't test this) - MINIO_ENABLE_FSMETA (Enable FSMETA all the time) Remove --ignore-disks option - this option was implemented when XL layer would initialize the backend disks and heal them automatically to disallow XL accidentally using the root partition itself this option was introduced. This behavior has been changed XL no longer automatically initializes `format.json` a HEAL is controlled activity, so ignore-disks is not useful anymore. This change also addresses the problems of our documentation going forward and keeps things simple. This patch brings in reduction of options and defaulting them to a valid known inputs. This patch also serves as a guideline of limiting many ways to do the same thing.
125 lines
3.6 KiB
Go
125 lines
3.6 KiB
Go
/*
|
|
* Minio Cloud Storage, (C) 2016 Minio, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"bytes"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func initFSObjects(disk string, t *testing.T) (obj ObjectLayer) {
|
|
endpoints, err := parseStorageEndpoints([]string{disk})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
obj, _, err = initObjectLayer(endpoints)
|
|
if err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
return obj
|
|
}
|
|
|
|
// TestReadFsMetadata - readFSMetadata testing with a healthy and faulty disk
|
|
func TestReadFSMetadata(t *testing.T) {
|
|
disk := filepath.Join(os.TempDir(), "minio-"+nextSuffix())
|
|
defer removeAll(disk)
|
|
|
|
obj := initFSObjects(disk, t)
|
|
|
|
fs := obj.(fsObjects)
|
|
|
|
bucketName := "bucket"
|
|
objectName := "object"
|
|
|
|
if err := obj.MakeBucket(bucketName); err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
sha256sum := ""
|
|
if _, err := obj.PutObject(bucketName, objectName, int64(len("abcd")), bytes.NewReader([]byte("abcd")),
|
|
map[string]string{"X-Amz-Meta-AppId": "a"}, sha256sum); err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
|
|
// Construct the full path of fs.json
|
|
fsPath := "buckets/" + bucketName + "/" + objectName + "/fs.json"
|
|
|
|
// Regular fs metadata reading, no errors expected
|
|
if _, err := readFSMetadata(fs.storage, ".minio.sys", fsPath); err != nil {
|
|
t.Fatal("Unexpected error ", err)
|
|
}
|
|
|
|
// Corrupted fs.json
|
|
if err := fs.storage.AppendFile(".minio.sys", fsPath, []byte{'a'}); err != nil {
|
|
t.Fatal("Unexpected error ", err)
|
|
}
|
|
if _, err := readFSMetadata(fs.storage, ".minio.sys", fsPath); err == nil {
|
|
t.Fatal("Should fail", err)
|
|
}
|
|
|
|
// Test with corrupted disk
|
|
fsStorage := fs.storage.(*posix)
|
|
naughty := newNaughtyDisk(fsStorage, nil, errFaultyDisk)
|
|
fs.storage = naughty
|
|
if _, err := readFSMetadata(fs.storage, ".minio.sys", fsPath); errorCause(err) != errFaultyDisk {
|
|
t.Fatal("Should fail", err)
|
|
}
|
|
|
|
}
|
|
|
|
// TestWriteFsMetadata - tests of writeFSMetadata with healthy and faulty disks
|
|
func TestWriteFSMetadata(t *testing.T) {
|
|
disk := filepath.Join(os.TempDir(), "minio-"+nextSuffix())
|
|
defer removeAll(disk)
|
|
obj := initFSObjects(disk, t)
|
|
fs := obj.(fsObjects)
|
|
|
|
bucketName := "bucket"
|
|
objectName := "object"
|
|
|
|
if err := obj.MakeBucket(bucketName); err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
sha256sum := ""
|
|
if _, err := obj.PutObject(bucketName, objectName, int64(len("abcd")), bytes.NewReader([]byte("abcd")),
|
|
map[string]string{"X-Amz-Meta-AppId": "a"}, sha256sum); err != nil {
|
|
t.Fatal("Unexpected err: ", err)
|
|
}
|
|
|
|
// Construct the complete path of fs.json
|
|
fsPath := "buckets/" + bucketName + "/" + objectName + "/fs.json"
|
|
|
|
// Fs metadata reading, no errors expected (healthy disk)
|
|
fsMeta, err := readFSMetadata(fs.storage, ".minio.sys", fsPath)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error ", err)
|
|
}
|
|
|
|
// Reading metadata with a corrupted disk
|
|
fsStorage := fs.storage.(*posix)
|
|
for i := 1; i <= 2; i++ {
|
|
naughty := newNaughtyDisk(fsStorage, map[int]error{i: errFaultyDisk, i + 1: errFaultyDisk}, nil)
|
|
fs.storage = naughty
|
|
if err = writeFSMetadata(fs.storage, ".minio.sys", fsPath, fsMeta); errorCause(err) != errFaultyDisk {
|
|
t.Fatal("Unexpected error", i, err)
|
|
|
|
}
|
|
}
|
|
|
|
}
|