maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Use math.MaxInt32 to signal unbounded parallelism

Browse source 
Downlevel versions of the Pulumi Node SDK assumed that a parallelism
level of zero implied serial execution, which current CLIs use to signal
unbounded parallelism. This commit works around the downlevel issue by
using math.MaxInt32 to signal unbounded parallelism.

(cherry picked from commit ca540cc736)
This commit is contained in:
Sean Gillespie 2018-10-29 10:24:04 -07:00 committed by Matt Ellis
parent b0a6766d96
commit 072a079833
5 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/destroy.go
View file

@ -133,7 +133,7 @@ func newDestroyCmd() *cobra.Command {
"Display operation as a rich diff showing the overall change")
cmd.PersistentFlags().IntVarP(
&parallel, "parallel", "p", defaultParallel,
"Allow P resource operations to run in parallel at once (1 for no parallelism, 0 for unbounded parallelism)")
"Allow P resource operations to run in parallel at once (1 for no parallelism). Defaults to unbounded.")
cmd.PersistentFlags().BoolVarP(
&refresh, "refresh", "r", false,
"Refresh the state of the stack's resources before this update")

2
cmd/preview.go
View file

@ -131,7 +131,7 @@ func newPreviewCmd() *cobra.Command {
"Display operation as a rich diff showing the overall change")
cmd.PersistentFlags().IntVarP(
&parallel, "parallel", "p", defaultParallel,
"Allow P resource operations to run in parallel at once (1 for no parallelism, 0 for unbounded parallelism)")
"Allow P resource operations to run in parallel at once (1 for no parallelism). Defaults to unbounded.")
cmd.PersistentFlags().BoolVar(
&showConfig, "show-config", false,
"Show configuration keys and variables")

2
cmd/refresh.go
View file

@ -142,7 +142,7 @@ func newRefreshCmd() *cobra.Command {
"Display operation as a rich diff showing the overall change")
cmd.PersistentFlags().IntVarP(
&parallel, "parallel", "p", defaultParallel,
"Allow P resource operations to run in parallel at once (1 for no parallelism, 0 for unbounded parallelism)")
"Allow P resource operations to run in parallel at once (1 for no parallelism). Defaults to unbounded.")
cmd.PersistentFlags().BoolVar(
&showReplacementSteps, "show-replacement-steps", false,
"Show detailed resource replacement creates and deletes instead of a single step")

5
cmd/up.go
View file

@ -17,6 +17,7 @@ package cmd
import (
"context"
"io/ioutil"
"math"
"os"
"github.com/pulumi/pulumi/pkg/tokens"
@ -36,7 +37,7 @@ import (
)
const (
defaultParallel = 0
defaultParallel = math.MaxInt32
)
// nolint: vetshadow, intentionally disabling here for cleaner err declaration/assignment.
@ -328,7 +329,7 @@ func newUpCmd() *cobra.Command {
"Display operation as a rich diff showing the overall change")
cmd.PersistentFlags().IntVarP(
&parallel, "parallel", "p", defaultParallel,
"Allow P resource operations to run in parallel at once (1 for no parallelism, 0 for unbounded parallelism)")
"Allow P resource operations to run in parallel at once (1 for no parallelism). Defaults to unbounded.")
cmd.PersistentFlags().BoolVarP(
&refresh, "refresh", "r", false,
"Refresh the state of the stack's resources before this update")

3
pkg/resource/deploy/plan.go
View file

@ -16,6 +16,7 @@ package deploy
import (
"context"
"math"
"github.com/blang/semver"
"github.com/pkg/errors"
@ -50,7 +51,7 @@ func (o Options) DegreeOfParallelism() int {
// InfiniteParallelism returns whether or not the requested level of parallelism is unbounded.
func (o Options) InfiniteParallelism() bool {
return o.Parallel == 0
return o.Parallel == math.MaxInt32
}
// Events is an interface that can be used to hook interesting engine/planning events.