Respond to some Pull Request feedback

This commit is contained in:
Matt Ellis 2018-03-09 09:59:57 -08:00
parent 96d39b60d1
commit 225975ae2d
2 changed files with 4 additions and 7 deletions

View file

@ -171,7 +171,7 @@ func displayPreludeEvent(out io.Writer, event engine.PreludeEventPayload, opts b
fmt.Fprint(out, opts.Color.Colorize(fmt.Sprintf("%v%v changes:%v\n", colors.SpecUnimportant, action, colors.Reset)))
}
//nolint: gas
// nolint: gas
func displayResourceOperationFailedEvent(out io.Writer,
event engine.ResourceOperationFailedPayload, opts backend.DisplayOptions) {

View file

@ -32,9 +32,9 @@ const (
DiagEvent EventType = "diag"
PreludeEvent EventType = "prelude"
SummaryEvent EventType = "summary"
ResourcePreEvent EventType = "resourcepre"
ResourceOutputsEvent EventType = "resourceoutputs"
ResourceOperationFailed EventType = "resourceoperationfailed"
ResourcePreEvent EventType = "resource-pre"
ResourceOutputsEvent EventType = "resource-outputs"
ResourceOperationFailed EventType = "resource-operationfailed"
)
func cancelEvent() Event {
@ -108,21 +108,18 @@ func makeEventEmitter(events chan<- Event, update Update) eventEmitter {
var f filter = &nopFilter{}
target := update.GetTarget()
if target.Config.HasSecureValue() {
var b bytes.Buffer
for _, v := range target.Config {
if !v.Secure() {
continue
}
if b.Len() > 0 {
b.WriteRune('|')
}
secret, err := v.Value(target.Decrypter)
contract.AssertNoError(err)
b.WriteString(regexp.QuoteMeta(secret))
}