maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Respond to some Pull Request feedback

Browse source
This commit is contained in:
Matt Ellis 2018-03-09 09:59:57 -08:00
parent 96d39b60d1
commit 225975ae2d
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/backend/local/display.go
View file

@ -171,7 +171,7 @@ func displayPreludeEvent(out io.Writer, event engine.PreludeEventPayload, opts b
fmt.Fprint(out, opts.Color.Colorize(fmt.Sprintf("%v%v changes:%v\n", colors.SpecUnimportant, action, colors.Reset))) fmt.Fprint(out, opts.Color.Colorize(fmt.Sprintf("%v%v changes:%v\n", colors.SpecUnimportant, action, colors.Reset)))
} }
//nolint: gas // nolint: gas
func displayResourceOperationFailedEvent(out io.Writer, func displayResourceOperationFailedEvent(out io.Writer,
event engine.ResourceOperationFailedPayload, opts backend.DisplayOptions) { event engine.ResourceOperationFailedPayload, opts backend.DisplayOptions) {

9
pkg/engine/events.go
View file

@ -32,9 +32,9 @@ const (
DiagEvent EventType = "diag" DiagEvent EventType = "diag"
PreludeEvent EventType = "prelude" PreludeEvent EventType = "prelude"
SummaryEvent EventType = "summary" SummaryEvent EventType = "summary"
ResourcePreEvent EventType = "resourcepre" ResourcePreEvent EventType = "resource-pre"
ResourceOutputsEvent EventType = "resourceoutputs" ResourceOutputsEvent EventType = "resource-outputs"
ResourceOperationFailed EventType = "resourceoperationfailed" ResourceOperationFailed EventType = "resource-operationfailed"
) )
func cancelEvent() Event { func cancelEvent() Event {
@ -108,21 +108,18 @@ func makeEventEmitter(events chan<- Event, update Update) eventEmitter {
var f filter = &nopFilter{} var f filter = &nopFilter{}
target := update.GetTarget() target := update.GetTarget()
if target.Config.HasSecureValue() { if target.Config.HasSecureValue() {
var b bytes.Buffer var b bytes.Buffer
for _, v := range target.Config { for _, v := range target.Config {
if !v.Secure() { if !v.Secure() {
continue continue
} }
if b.Len() > 0 { if b.Len() > 0 {
b.WriteRune('|') b.WriteRune('|')
} }
secret, err := v.Value(target.Decrypter) secret, err := v.Value(target.Decrypter)
contract.AssertNoError(err) contract.AssertNoError(err)
b.WriteString(regexp.QuoteMeta(secret)) b.WriteString(regexp.QuoteMeta(secret))
} }