maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Flip the order of comparison for static cast checking

Browse source
This commit is contained in:
joeduffy 2017-02-16 07:38:10 -08:00
parent 79569b9044
commit 231d697181
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/compiler/binder/stmtexpr.go
View file

@ -647,10 +647,11 @@ func (a *astBinder) checkBinaryOperatorExpression(node *ast.BinaryOperatorExpres
}
func (a *astBinder) checkCastExpression(node *ast.CastExpression) {
// If we know statically that the cast is invalid, issue an error. Otherwise, defer to runtime.
// If we know statically that the cast is invalid -- that is, the destination type could never have been converted
// to the source type -- issue an error. Otherwise, defer to runtime.
from := a.b.ctx.RequireType(node.Expression)
to := a.b.ctx.LookupType(node.Type)
if !types.CanConvert(from, to) {
if !types.CanConvert(to, from) {
a.b.Diag().Errorf(errors.ErrorInvalidCast.At(node), from, to)
}
a.b.ctx.RegisterType(node, to)