various fixes to get build running on mac (#3454)

CONTRIBUTING.md

@@ -8,7 +8,7 @@ For larger features, we'd appreciate it if you open a [new issue](https://github
 
 To hack on Pulumi, you'll need to get a development environment set up. You'll want to install the following on your machine:
 
-- Go 1.12 or later
+- Go 1.12
 - NodeJS 6.10.X or later
 - Python 3.6 or later
 - [.NET Core](https://dotnet.microsoft.com/download)
@@ -21,7 +21,7 @@ To hack on Pulumi, you'll need to get a development environment set up. You'll w
 You can easily get all required dependencies with brew and npm
 
 ```bash
-brew install node pipenv python@3 typescript yarn go golangci/tap/golangci-lint
+brew install node pipenv python@3 typescript yarn go@1.12 golangci/tap/golangci-lint
 brew cask install dotnet dotnet-sdk
 ```
 
@@ -37,6 +37,13 @@ sudo chown <your_user_name>: /opt/pulumi
 export PATH=/opt/pulumi:/opt/pulumi/bin:$PATH
 ```
 
+You'll also need to make sure your maximum open file descriptor limit is set to 2048 at a minimum.
+
+```bash
+ulimit -n # to test
+ulimit -n 2048
+```
+
 Across our projects, we try to use a regular set of make targets. The ones you'll care most about are:
 
 0. `make ensure`, which restores/installs any build dependencies

go.mod

@@ -31,8 +31,6 @@ require (
 	github.com/mitchellh/go-ps v0.0.0-20170309133038-4fdf99ab2936
 	github.com/mxschmitt/golang-combinations v1.0.0
 	github.com/nbutton23/zxcvbn-go v0.0.0-20171102151520-eafdab6b0663
-	github.com/onsi/ginkgo v1.7.0 // indirect
-	github.com/onsi/gomega v1.4.3 // indirect
 	github.com/opentracing/basictracer-go v1.0.0 // indirect
 	github.com/opentracing/opentracing-go v1.0.2
 	github.com/pkg/errors v0.8.1

pkg/apitype/stacks.go

@@ -41,7 +41,7 @@ type CreateStackRequest struct {
 	StackName string `json:"stackName"`
 
 	// An optional set of tags to apply to the stack.
-	Tags map[StackTagName]string `json:"tags,omitEmpty"`
+	Tags map[StackTagName]string `json:"tags,omitempty"`
 }
 
 // CreateStackResponse is the response from a create Stack request.

pkg/backend/httpstate/client/client.go

@@ -205,7 +205,7 @@ var (
 // GetLatestConfiguration returns the configuration for the latest deployment of a given stack.
 func (pc *Client) GetLatestConfiguration(ctx context.Context, stackID StackIdentifier) (config.Map, error) {
 	latest := struct {
-		Info apitype.UpdateInfo `json:"info,allowEmpty"`
+		Info apitype.UpdateInfo `json:"info,omitempty"`
 	}{}
 
 	if err := pc.restCall(ctx, "GET", getStackPath(stackID, "updates", "latest"), nil, nil, &latest); err != nil {

sdk/dotnet/Makefile

@@ -52,6 +52,8 @@ lint::
 
 dotnet_test::
 	dotnet test
+	# work around a bug where running `dotnet test` disables console stdinput display
+	stty echo
 
 test_fast:: dotnet_test
 	$(GO_TEST_FAST) ${PROJECT_PKGS}