From 55df0cc2017ee4a04bfc9eec8792c18f8c8a1597 Mon Sep 17 00:00:00 2001 From: "pat@pulumi.com" Date: Tue, 12 Dec 2017 14:32:27 -0800 Subject: [PATCH] PR feedback --- pkg/engine/plan.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/engine/plan.go b/pkg/engine/plan.go index b708f04f8..764655606 100644 --- a/pkg/engine/plan.go +++ b/pkg/engine/plan.go @@ -601,6 +601,12 @@ func printPropertyValue( write(b, op, "archive(uri:%s) { %v }", shortHash(a.Hash), a.URI) } } else if v.IsComputed() || v.IsOutput() { + // We render computed and output values differently depending on whether or not we are planning or deploying: + // in the former case, we display `computed` or `output`; in the former we display `undefined`. + // This is because we currently cannot distinguish between user-supplied undefined values and input properties + // that are undefined because they were sourced from undefined values in other resources' output properties. + // Once we have richer information about the dataflow between resources, we should be able to do a better job + // here (pulumi/pulumi#234). if planning { writeVerbatim(b, op, v.TypeString()) } else {