maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[sdk/go] Minor optimization in Go provider

Browse source 
First check for empty deps before checking to see if the gathered dependencies are equivalent to the specified dependencies map.
This commit is contained in:
Justin Van Patten 2021-11-12 15:29:11 -08:00
parent 7487e99d94
commit 97daa0a34a
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
sdk/go/pulumi/provider.go
View file

@ -215,6 +215,13 @@ func (ci constructInput) Dependencies(ctx *Context) []Resource {
return result
}
// HasEquivalentDependencies returns true if the deps are equal to or a subset of the gathered nested dependencies.
func (ci constructInput) HasEquivalentDependencies() bool {
deps := urnSet{}
gatherDeps(ci.value, deps)
return deps.contains(ci.deps)
}
// constructInputsMap returns the inputs as a Map.
func constructInputsMap(ctx *Context, inputs map[string]interface{}) (Map, error) {
result := make(Map, len(inputs))
@ -577,13 +584,9 @@ func constructInputsCopyTo(ctx *Context, inputs map[string]interface{}, args int
continue
}
// Find all nested dependencies.
deps := urnSet{}
gatherDeps(ci.value, deps)
// If the top-level property dependencies are equal to (or a subset of) the gathered nested
// dependencies, we don't necessarily need to create a top-level output for the property.
if deps.contains(ci.deps) {
// If there aren't any dependencies or the dependencies are equivalent, we don't necessarily
// need to create a top-level output for the property.
if len(ci.deps) == 0 || ci.HasEquivalentDependencies() {
if err := copyInputTo(ctx, ci.value, fieldV); err != nil {
return fmt.Errorf("copying input %q: %w", k, err)
}