From 98ef06ecb855bc5d7d362c0bf9c10d7b42254925 Mon Sep 17 00:00:00 2001 From: Anton Tayanovskyy Date: Thu, 30 Sep 2021 18:56:42 +0000 Subject: [PATCH] Go codegen flag to disable fnOutput generation to save space (#8106) --- pkg/codegen/go/gen.go | 21 +++++++++++++++++++-- pkg/codegen/go/importer.go | 4 ++++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/pkg/codegen/go/gen.go b/pkg/codegen/go/gen.go index 339af58a7..6ff800f3b 100644 --- a/pkg/codegen/go/gen.go +++ b/pkg/codegen/go/gen.go @@ -1734,13 +1734,30 @@ func (pkg *pkgContext) genResource(w io.Writer, r *schema.Resource, generateReso return nil } +func (pkg *pkgContext) needsGoOutputVersion(f *schema.Function) bool { + fPkg := f.Package + + var goInfo GoPackageInfo + + contract.AssertNoError(fPkg.ImportLanguages(map[string]schema.Language{"go": Importer})) + if info, ok := fPkg.Language["go"].(GoPackageInfo); ok { + goInfo = info + } + + if goInfo.DisableFunctionOutputVersions { + return false + } + + return f.NeedsOutputVersion() +} + func (pkg *pkgContext) genFunctionCodeFile(f *schema.Function) string { importsAndAliases := map[string]string{} pkg.getImports(f, importsAndAliases) buffer := &bytes.Buffer{} var imports []string - if f.NeedsOutputVersion() { + if pkg.needsGoOutputVersion(f) { imports = []string{"context", "reflect"} } @@ -1831,7 +1848,7 @@ func (pkg *pkgContext) functionResultTypeName(f *schema.Function) string { } func (pkg *pkgContext) genFunctionOutputVersion(w io.Writer, f *schema.Function) { - if !f.NeedsOutputVersion() { + if !pkg.needsGoOutputVersion(f) { return } diff --git a/pkg/codegen/go/importer.go b/pkg/codegen/go/importer.go index c6a77c3e1..b40355974 100644 --- a/pkg/codegen/go/importer.go +++ b/pkg/codegen/go/importer.go @@ -49,6 +49,10 @@ type GoPackageInfo struct { // The version of the Pulumi SDK used with this provider, e.g. 3. // Used to generate doc links for pulumi builtin types. If omitted, the latest SDK version is used. PulumiSDKVersion int `json:"pulumiSDKVersion,omitempty"` + + // Feature flag to disable generating `$fnOutput` invoke + // function versions to save space. + DisableFunctionOutputVersions bool `json:"disableFunctionOutputVersions,omitempty"` } // Importer implements schema.Language for Go.