maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

TODO and comment fixup

Browse source
This commit is contained in:
Luke Hoban 2017-11-26 09:57:41 -08:00
parent 6c694dd959
commit a79b3ab50f
4 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/backend_cloud.go
View file

@ -228,7 +228,7 @@ func uploadProgram(uploadURL string, printSize bool) error {
func (b *pulumiCloudPulumiBackend) GetLogs(stackName tokens.QName, query operations.LogQuery) ([]operations.LogEntry, error) {
// TODO[pulumi/pulumi-service#227]: Relax these conditions once the service can take these arguments.
if query.StartTime != nil || query.EndTime != nil || query.Query != nil {
return nil, errors.New("not implemented")
return nil, errors.New("cloud backend does not (yet) support filtering logs by start time, end time or message contents")
}
projID, err := getCloudProjectIdentifier()

1
cmd/backend_local.go
View file

@ -156,7 +156,6 @@ func (b *localPulumiBackend) GetLogs(stackName tokens.QName, query operations.Lo
contract.Assert(snap != nil)
contract.Assert(target != nil)
// TODO[pulumi/pulumi#54]: replace this with a call into a generalized operations provider.
components := operations.NewResource(snap.Resources)
ops := components.OperationsProvider(target.Config)
logs, err := ops.GetLogs(query)

5
pkg/operations/operations_aws.go
View file

@ -17,8 +17,11 @@ import (
"github.com/pulumi/pulumi/pkg/util/contract"
)
// TODO[pulumi/pulumi#54] This should be factored out behind an OperationsProvider RPC interface and versioned with the
// `pulumi-aws` repo instead of statically linked into the engine.
// AWSOperationsProvider creates an OperationsProvider capable of answering operational queries based on the
// underlying resources of the `@pulumi/cloud-aws` implementation.
// underlying resources of the `@pulumi/aws` implementation.
func AWSOperationsProvider(
config map[tokens.ModuleMember]string,
component *Resource) (Provider, error) {

3
pkg/operations/operations_cloud_aws.go
View file

@ -10,6 +10,9 @@ import (
"github.com/pulumi/pulumi/pkg/util/contract"
)
// TODO[pulumi/pulumi#54] This should be factored out behind an OperationsProvider RPC interface and versioned with the
// `pulumi-cloud` repo instead of statically linked into the engine.
// CloudOperationsProvider creates an OperationsProvider capable of answering operational queries based on the
// underlying resources of the `@pulumi/cloud-aws` implementation.
func CloudOperationsProvider(config map[tokens.ModuleMember]string, component *Resource) (Provider, error) {