maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix preview display for replacements (#1945)

Browse source 
* Fix preview display for replacements

* Make gometalinter happy
This commit is contained in:
Sean Gillespie 2018-09-17 10:50:11 -07:00 committed by GitHub
parent 937391259e
commit b98c5bb0d9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 30 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
pkg/backend/display/progress.go
View file

@ -1004,9 +1004,9 @@ func (display *ProgressDisplay) getStepDoneDescription(step engine.StepEventMeta
op := display.getStepOp(step)
if display.isPreview {
// During a preview, when we transition to done, we still just print the same thing we
// did while running the step.
return op.Color() + display.getPreviewText(step) + colors.Reset
// During a preview, when we transition to done, we'll print out summary text describing the step instead of a
// past-tense verb describing the step that was performed.
return op.Color() + display.getPreviewDoneText(step) + colors.Reset
}
// most of the time a stack is unchanged. in that case we just show it as "running->done"
@ -1050,6 +1050,7 @@ func (display *ProgressDisplay) getStepDoneDescription(step engine.StepEventMeta
case deploy.OpDeleteReplaced:
return "deleted original"
case deploy.OpRead:
// nolint: goconst
return "read"
case deploy.OpReadReplacement:
return "read for replacement"
@ -1086,6 +1087,7 @@ func (display *ProgressDisplay) getPreviewText(step engine.StepEventMetadata) st
case deploy.OpDeleteReplaced:
return "delete original"
case deploy.OpRead:
// nolint: goconst
return "read"
case deploy.OpReadReplacement:
return "read for replacement"
@ -1097,6 +1099,31 @@ func (display *ProgressDisplay) getPreviewText(step engine.StepEventMetadata) st
return ""
}
// getPreviewDoneText returns a textual representation for this step, suitable for display during a preview once the
// preview has completed.
func (display *ProgressDisplay) getPreviewDoneText(step engine.StepEventMetadata) string {
switch step.Op {
case deploy.OpSame:
return "no change"
case deploy.OpCreate:
return "create"
case deploy.OpUpdate:
return "update"
case deploy.OpDelete:
return "delete"
case deploy.OpReplace, deploy.OpCreateReplacement, deploy.OpDeleteReplaced, deploy.OpReadReplacement:
return "replace"
case deploy.OpRead:
// nolint: goconst
return "read"
case deploy.OpRefresh:
return "refresh"
}
contract.Failf("Unrecognized resource step op: %v", step.Op)
return ""
}
func (display *ProgressDisplay) getStepOp(step engine.StepEventMetadata) deploy.StepOp {
op := step.Op