maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #512 from pulumi/makefile-cleanup

Browse source 
Small Makefile improvements
This commit is contained in:
Matt Ellis 2017-11-01 11:00:01 -07:00 committed by GitHub
parent 41562527f7 0815ef5ec9
commit cfdf62511d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
Makefile
View file

@ -17,7 +17,7 @@ all: banner_all core sdk/nodejs integrationtest
nightly: all gocover
.PHONY: core
core: vet test install lint_quiet
core: test install lint
.PHONY: banner
banner:
@ -43,31 +43,24 @@ install:
format:
find . -iname "*.go" -not -path "./vendor/*" | xargs gofmt -s -w
.PHONY: lint
lint:
@$(ECHO) "\033[0;32mLINT:\033[0m"
.PHONY: lint_full
lint_full:
@$(ECHO) "\033[0;32mLINT (full):\033[0m"
$(GOMETALINTER) main.go | sort ; exit "$${PIPESTATUS[0]}"
$(GOMETALINTER) ./pkg/... | sort ; exit "$${PIPESTATUS[0]}"
$(GOMETALINTER) ./cmd/... | sort ; exit "$${PIPESTATUS[0]}"
# In quiet mode, suppress some messages.
# - "or be unexported": TODO[pulumi/pulumi#191]: will fix when we write all of our API docs
# - "Subprocess launching with variable": we intentionally launch processes dynamically.
# - "cyclomatic complexity" (disabled in config): TODO[pulumi/pulumi#259]: need to fix many of these.
LINT_SUPPRESS="or be unexported|Subprocess launching with variable"
LINT_SUPPRESS="or be unexported"
.PHONY: lint_quiet
lint_quiet:
@$(ECHO) "\033[0;32mLINT (quiet):\033[0m"
.PHONY: lint
lint:
@$(ECHO) "\033[0;32mLINT:\033[0m"
$(GOMETALINTER) main.go | grep -vE ${LINT_SUPPRESS} | sort ; exit $$(($${PIPESTATUS[1]}-1))
$(GOMETALINTER) ./pkg/... | grep -vE ${LINT_SUPPRESS} | sort ; exit $$(($${PIPESTATUS[1]}-1))
$(GOMETALINTER) ./cmd/... | grep -vE ${LINT_SUPPRESS} | sort ; exit $$(($${PIPESTATUS[1]}-1))
@$(ECHO) "\033[0;33mlint was run quietly; to run with noisy errors, run 'make lint'\033[0m"
.PHONY: vet
vet:
@$(ECHO) "\033[0;32mVET:\033[0m"
go tool vet -printf=false cmd/ pkg/
@$(ECHO) "\033[0;33mlint was run quietly; to run with noisy errors, run 'make lint_full'\033[0m"
.PHONY: test
test:
@ -78,8 +71,7 @@ test:
integrationtest:
@$(ECHO) "\033[0;32mINTEGRATION TEST:\033[0m"
@if [ -z "`which pulumi-langhost-nodejs`" ]; then $(ECHO) Please add "`pwd`/sdk/nodejs/bin" to your path before running integration tests. && exit 1; fi
go test -cover -parallel ${TESTPARALLELISM} ./examples
go test ./tests/...
go test -cover -parallel ${TESTPARALLELISM} ./examples ./tests
sdk/nodejs:
@cd ./sdk/nodejs && $(MAKE)