maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Assert that all expressions have types

Browse source 
This is a bit of paranoia, however, an invariant of the typechecker
is that, after the final pass, all expression nodes are assigned a
type.  This assertion checks that this is true.
This commit is contained in:
joeduffy 2017-01-21 14:39:20 -08:00
parent 9fe2f28e7b
commit d907e358ad
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/compiler/binder/function.go
View file

@ -7,6 +7,7 @@ import (
"github.com/marapongo/mu/pkg/compiler/errors"
"github.com/marapongo/mu/pkg/compiler/symbols"
"github.com/marapongo/mu/pkg/compiler/types"
"github.com/marapongo/mu/pkg/util/contract"
)
// bindFunctionBody binds a function body, including a scope, its parameters, and its expressions and statements.
@ -162,6 +163,10 @@ func (a *astBinder) After(node ast.Node) {
// TODO: check that there's at least one!
a.b.registerExprType(n, a.b.requireExprType(n.Expressions[len(n.Expressions)-1]))
}
// Ensure that all expression types resulted in a type registration.
expr, isExpr := node.(ast.Expression)
contract.Assert(!isExpr || a.b.requireExprType(expr) != nil)
}
func (a *astBinder) checkExprType(expr ast.Expression, expect symbols.Type) bool {