Only replace secret text if it is longer than 2 characters
This is inline with what Travis does. Otherwise, for very short secrets our regex based approach will throw `[secret]` all over the place.
This commit is contained in:
parent
936cab0c22
commit
dc57119206
|
@ -114,16 +114,23 @@ func makeEventEmitter(events chan<- Event, update Update) eventEmitter {
|
||||||
if !v.Secure() {
|
if !v.Secure() {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
secret, err := v.Value(target.Decrypter)
|
||||||
|
contract.AssertNoError(err)
|
||||||
|
|
||||||
|
// For short secrets, don't actually add them to the filter, this is a trade-off we make to prevent
|
||||||
|
// displaying `[secret]`. Travis does a similar thing, for example.
|
||||||
|
if len(secret) < 3 {
|
||||||
|
continue
|
||||||
|
}
|
||||||
if b.Len() > 0 {
|
if b.Len() > 0 {
|
||||||
b.WriteRune('|')
|
b.WriteRune('|')
|
||||||
}
|
}
|
||||||
|
|
||||||
secret, err := v.Value(target.Decrypter)
|
|
||||||
contract.AssertNoError(err)
|
|
||||||
b.WriteString(regexp.QuoteMeta(secret))
|
b.WriteString(regexp.QuoteMeta(secret))
|
||||||
}
|
}
|
||||||
|
if b.Len() > 0 {
|
||||||
f = ®exFilter{re: regexp.MustCompile(b.String())}
|
f = ®exFilter{re: regexp.MustCompile(b.String())}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return eventEmitter{
|
return eventEmitter{
|
||||||
|
|
Loading…
Reference in a new issue