maxmustermann/pulumi
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Implement GetSchema in dynamic providers (#4083)

Browse source 
It's not entirely clear why gRPC doesn't already report these cleanly as unimplemented, but for now we'll explicitly implement them to avoid any spurious warnings.

Fixes #4028.
This commit is contained in:
Luke Hoban 2020-03-15 15:36:08 -07:00 committed by GitHub
parent b6e5d2737d
commit fdd9a57ff8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sdk/nodejs/cmd/dynamic-provider/index.ts
View file

@ -263,6 +263,13 @@ async function getPluginInfoRPC(call: any, callback: any): Promise<void> {
callback(undefined, resp);
}
function getSchemaRPC(call: any, callback: any): void {
callback({
code: grpc.status.UNIMPLEMENTED,
details: "GetSchema is not implemented by the dynamic provider",
}, undefined);
}
function resultIncludingProvider(result: any, props: any): any {
return Object.assign(result || {}, {
[providerKey]: props[providerKey],
@ -335,6 +342,7 @@ export function main(args: string[]): void {
update: updateRPC,
delete: deleteRPC,
getPluginInfo: getPluginInfoRPC,
getSchema: getSchemaRPC,
});
const port: number = server.bind(`0.0.0.0:0`, grpc.ServerCredentials.createInsecure());

5
sdk/python/lib/pulumi/dynamic/__main__.py
View file

@ -143,6 +143,11 @@ class DynamicResourceProviderServicer(ResourceProviderServicer):
fields = {"version": "0.1.0"}
return proto.PluginInfo(**fields)
def GetSchema(self, request, context):
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
context.set_details("GetSchema is not implemented by the dynamic provider")
raise NotImplementedError("GetSchema is not implemented by the dynamic provider")
def Read(self, request, context):
id_ = request.id
props = rpc.deserialize_properties(request.properties)