pulumi/pkg
Pat Gavlin 52d01bb915
[codegen/go] Remove ResourcePtr input/output types (#8449)
These changes remove the `Ptr` variants of input/ouptut types for
resources. A `TPtr` input or output is normally generated for `T` if `T`
is present in an `optional(input(T))` or `optional(output(T))` and if
the Go representation for `T` is not nilable. The generation of `Ptr`
variants for resource types breaks the latter rule: the canonical
representation of a resource type named `Foo` is a pointer to a struct
type named `Foo` (i.e. `*Foo`). `Foo` itself is not a resource, as it
does not implement the Go `Resource` interface. Because this
representation already accommodates `nil` to indicate the lack of a
value, we need not generate `FooPtr{Input,Output}` types.

Besides being unnecessary, the implementation of `Ptr` types for
resources was incorrect. Rather than using `**Foo` as their element
type, these types use `*Foo`--identical to the element type used for
the normal input/output types. Furthermore, the generated code for
at least `FooOutput.ToFooPtrOutputWithContext` and `FooPtrOutput.Elem`
was incorrect, making these types virtually unusable in practice.

Finally, these `Ptr` types should never appear on input/output
properties in practice, as the logic we use to generate input and output
type references never generates them for `optional({input,output}(T)).
Instead, it generates references to the standard input/output types.

Though this is _technically_ a breaking change--it changes the set of
exported types for any package that defines resources--I believe that in
practice it will be invisible to users for the reasons stated above.
These types are not usable, and were never referenced.

This is preparatory work for #7943.
2021-11-23 10:24:56 -08:00
..
backend [backend/filestate] Don't unwrap go-cloud errors (#8455) 2021-11-19 12:21:37 -08:00
cmd/pulumi Implement the --exclude-protected feature (#8359) 2021-11-15 11:45:14 -08:00
codegen [codegen/go] Remove ResourcePtr input/output types (#8449) 2021-11-23 10:24:56 -08:00
engine Update command respects --target-dependents (#8395) 2021-11-16 17:12:36 -08:00
graph Update error handling (#8406) 2021-11-12 18:37:17 -08:00
operations Update error handling (#8406) 2021-11-12 18:37:17 -08:00
resource [FIX] unprotect cmd example (#8430) 2021-11-19 12:39:34 -08:00
secrets Update error handling (#8406) 2021-11-12 18:37:17 -08:00
testing/integration Move /opt/pulumi to $HOME/.pulumi (#8437) 2021-11-17 10:37:38 -08:00
util Update error handling (#8406) 2021-11-12 18:37:17 -08:00
version duplicate version to ensure linking is properly handled 2020-03-19 12:49:34 -07:00
go.mod Update pkg -> sdk dependency (#8481) 2021-11-22 14:39:54 -08:00
go.sum Update pkg -> sdk dependency (#8442) 2021-11-17 15:24:09 -08:00