pulumi/pkg/operations/resources_test.go
Pat Gavlin 1ecdc83a33 Implement more precise delete-before-replace semantics. (#2369)
This implements the new algorithm for deciding which resources must be
deleted due to a delete-before-replace operation.

We need to compute the set of resources that may be replaced by a
change to the resource under consideration. We do this by taking the
complete set of transitive dependents on the resource under
consideration and removing any resources that would not be replaced by
changes to their dependencies. We determine whether or not a resource
may be replaced by substituting unknowns for input properties that may
change due to deletion of the resources their value depends on and
calling the resource provider's Diff method.

This is perhaps clearer when described by example. Consider the
following dependency graph:

  A
__|__
B   C
|  _|_
D  E F

In this graph, all of B, C, D, E, and F transitively depend on A. It may
be the case, however, that changes to the specific properties of any of
those resources R that would occur if a resource on the path to A were
deleted and recreated may not cause R to be replaced. For example, the
edge from B to A may be a simple dependsOn edge such that a change to
B does not actually influence any of B's input properties. In that case,
neither B nor D would need to be deleted before A could be deleted.

In order to make the above algorithm a reality, the resource monitor
interface has been updated to include a map that associates an input
property key with the list of resources that input property depends on.
Older clients of the resource monitor will leave this map empty, in
which case all input properties will be treated as depending on all
dependencies of the resource. This is probably overly conservative, but
it is less conservative than what we currently implement, and is
certainly correct.
2019-01-28 09:46:30 -08:00

114 lines
3.4 KiB
Go

// Copyright 2016-2018, Pulumi Corporation.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package operations
import (
"encoding/json"
"io/ioutil"
"testing"
"github.com/davecgh/go-spew/spew"
"github.com/stretchr/testify/assert"
"github.com/pulumi/pulumi/pkg/apitype"
"github.com/pulumi/pulumi/pkg/resource/stack"
)
func getPulumiResources(t *testing.T, path string) *Resource {
var checkpoint apitype.CheckpointV3
byts, err := ioutil.ReadFile(path)
assert.NoError(t, err)
err = json.Unmarshal(byts, &checkpoint)
assert.NoError(t, err)
snapshot, err := stack.DeserializeCheckpoint(&checkpoint)
assert.NoError(t, err)
resources := NewResourceTree(snapshot.Resources)
spew.Dump(resources)
return resources
}
func TestTodo(t *testing.T) {
components := getPulumiResources(t, "testdata/todo.json")
assert.Equal(t, 4, len(components.Children))
// Table child
table, ok := components.GetChild("cloud:table:Table", "todo")
assert.True(t, ok)
if !assert.NotNil(t, table) {
return
}
assert.Equal(t, 2, len(table.State.Inputs))
assert.Equal(t, "id", table.State.Inputs["primaryKey"].StringValue())
assert.Equal(t, 1, len(table.Children))
table, ok = table.GetChild("aws:dynamodb/table:Table", "todo")
assert.True(t, ok)
assert.NotNil(t, table)
// Endpoint child
endpoint, ok := components.GetChild("cloud:http:HttpEndpoint", "todo")
assert.True(t, ok)
if !assert.NotNil(t, endpoint) {
return
}
assert.Equal(t, 5, len(endpoint.State.Inputs))
assert.Equal(t,
"https://eupwl7wu4i.execute-api.us-east-2.amazonaws.com/", endpoint.State.Inputs["url"].StringValue())
assert.Equal(t, 14, len(endpoint.Children))
endpoint, ok = endpoint.GetChild("aws:apigateway/restApi:RestApi", "todo")
assert.True(t, ok)
assert.NotNil(t, endpoint)
// Nonexistant resource.
r, ok := endpoint.GetChild("garden:ornimentation/gnome", "stone")
assert.False(t, ok)
assert.Nil(t, r)
}
func TestCrawler(t *testing.T) {
components := getPulumiResources(t, "testdata/crawler.json")
assert.Equal(t, 7, len(components.Children))
// Topic child
topic, ok := components.GetChild("cloud:topic:Topic", "countDown")
assert.True(t, ok)
if !assert.NotNil(t, topic) {
return
}
assert.Equal(t, 0, len(topic.State.Inputs))
assert.Equal(t, 1, len(topic.Children))
topic, ok = topic.GetChild("aws:sns/topic:Topic", "countDown")
assert.True(t, ok)
assert.NotNil(t, topic)
// Timer child
heartbeat, ok := components.GetChild("cloud:timer:Timer", "heartbeat")
assert.True(t, ok)
if !assert.NotNil(t, heartbeat) {
return
}
assert.Equal(t, 1, len(heartbeat.State.Inputs))
assert.Equal(t, "rate(5 minutes)", heartbeat.State.Inputs["scheduleExpression"].StringValue())
assert.Equal(t, 4, len(heartbeat.Children))
// Function child of timer
function, ok := heartbeat.GetChild("cloud:function:Function", "heartbeat")
assert.True(t, ok)
if !assert.NotNil(t, function) {
return
}
assert.Equal(t, 1, len(function.State.Inputs))
assert.Equal(t, 3, len(function.Children))
}