52d01bb915
These changes remove the `Ptr` variants of input/ouptut types for
resources. A `TPtr` input or output is normally generated for `T` if `T`
is present in an `optional(input(T))` or `optional(output(T))` and if
the Go representation for `T` is not nilable. The generation of `Ptr`
variants for resource types breaks the latter rule: the canonical
representation of a resource type named `Foo` is a pointer to a struct
type named `Foo` (i.e. `*Foo`). `Foo` itself is not a resource, as it
does not implement the Go `Resource` interface. Because this
representation already accommodates `nil` to indicate the lack of a
value, we need not generate `FooPtr{Input,Output}` types.
Besides being unnecessary, the implementation of `Ptr` types for
resources was incorrect. Rather than using `**Foo` as their element
type, these types use `*Foo`--identical to the element type used for
the normal input/output types. Furthermore, the generated code for
at least `FooOutput.ToFooPtrOutputWithContext` and `FooPtrOutput.Elem`
was incorrect, making these types virtually unusable in practice.
Finally, these `Ptr` types should never appear on input/output
properties in practice, as the logic we use to generate input and output
type references never generates them for `optional({input,output}(T)).
Instead, it generates references to the standard input/output types.
Though this is _technically_ a breaking change--it changes the set of
exported types for any package that defines resources--I believe that in
practice it will be invisible to users for the reasons stated above.
These types are not usable, and were never referenced.
This is preparatory work for #7943.
84 lines
2.2 KiB
Go
84 lines
2.2 KiB
Go
// *** WARNING: this file was generated by test. ***
|
|
// *** Do not edit by hand unless you're certain you know what you are doing! ***
|
|
|
|
package example
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
|
|
"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
|
|
)
|
|
|
|
type OtherResource struct {
|
|
pulumi.ResourceState
|
|
|
|
Foo ResourceOutput `pulumi:"foo"`
|
|
}
|
|
|
|
// NewOtherResource registers a new resource with the given unique name, arguments, and options.
|
|
func NewOtherResource(ctx *pulumi.Context,
|
|
name string, args *OtherResourceArgs, opts ...pulumi.ResourceOption) (*OtherResource, error) {
|
|
if args == nil {
|
|
args = &OtherResourceArgs{}
|
|
}
|
|
|
|
var resource OtherResource
|
|
err := ctx.RegisterRemoteComponentResource("example::OtherResource", name, args, &resource, opts...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &resource, nil
|
|
}
|
|
|
|
type otherResourceArgs struct {
|
|
Foo *Resource `pulumi:"foo"`
|
|
}
|
|
|
|
// The set of arguments for constructing a OtherResource resource.
|
|
type OtherResourceArgs struct {
|
|
Foo ResourceInput
|
|
}
|
|
|
|
func (OtherResourceArgs) ElementType() reflect.Type {
|
|
return reflect.TypeOf((*otherResourceArgs)(nil)).Elem()
|
|
}
|
|
|
|
type OtherResourceInput interface {
|
|
pulumi.Input
|
|
|
|
ToOtherResourceOutput() OtherResourceOutput
|
|
ToOtherResourceOutputWithContext(ctx context.Context) OtherResourceOutput
|
|
}
|
|
|
|
func (*OtherResource) ElementType() reflect.Type {
|
|
return reflect.TypeOf((**OtherResource)(nil)).Elem()
|
|
}
|
|
|
|
func (i *OtherResource) ToOtherResourceOutput() OtherResourceOutput {
|
|
return i.ToOtherResourceOutputWithContext(context.Background())
|
|
}
|
|
|
|
func (i *OtherResource) ToOtherResourceOutputWithContext(ctx context.Context) OtherResourceOutput {
|
|
return pulumi.ToOutputWithContext(ctx, i).(OtherResourceOutput)
|
|
}
|
|
|
|
type OtherResourceOutput struct{ *pulumi.OutputState }
|
|
|
|
func (OtherResourceOutput) ElementType() reflect.Type {
|
|
return reflect.TypeOf((**OtherResource)(nil)).Elem()
|
|
}
|
|
|
|
func (o OtherResourceOutput) ToOtherResourceOutput() OtherResourceOutput {
|
|
return o
|
|
}
|
|
|
|
func (o OtherResourceOutput) ToOtherResourceOutputWithContext(ctx context.Context) OtherResourceOutput {
|
|
return o
|
|
}
|
|
|
|
func init() {
|
|
pulumi.RegisterInputType(reflect.TypeOf((*OtherResourceInput)(nil)).Elem(), &OtherResource{})
|
|
pulumi.RegisterOutputType(OtherResourceOutput{})
|
|
}
|