pulumi/cmd/up.go
Pat Gavlin 6e5c4a38d8
Defer all diffs to resource providers. (#2849)
Thse changes make a subtle but critical adjustment to the process the
Pulumi engine uses to determine whether or not a difference exists
between a resource's actual and desired states, and adjusts the way this
difference is calculated and displayed accordingly.

Today, the Pulumi engine get the first chance to decide whether or not
there is a difference between a resource's actual and desired states. It
does this by comparing the current set of inputs for a resource (i.e.
the inputs from the running Pulumi program) with the last set of inputs
used to update the resource. If there is no difference between the old
and new inputs, the engine decides that no change is necessary without
consulting the resource's provider. Only if there are changes does the
engine consult the resource's provider for more information about the
difference. This can be problematic for a number of reasons:

- Not all providers do input-input comparison; some do input-state
  comparison
- Not all providers are able to update the last deployed set of inputs
  when performing a refresh
- Some providers--either intentionally or due to bugs--may see changes
  in resources whose inputs have not changed

All of these situations are confusing at the very least, and the first
is problematic with respect to correctness. Furthermore, the display
code only renders diffs it observes rather than rendering the diffs
observed by the provider, which can obscure the actual changes detected
at runtime.

These changes address both of these issues:
- Rather than comparing the current inputs against the last inputs
  before calling a resource provider's Diff function, the engine calls
  the Diff function in all cases.
- Providers may now return a list of properties that differ between the
  requested and actual state and the way in which they differ. This
  information will then be used by the CLI to render the diff
  appropriately. A provider may also indicate that a particular diff is
  between old and new inputs rather than old state and new inputs.

Fixes #2453.
2019-07-01 12:34:19 -07:00

526 lines
16 KiB
Go

// Copyright 2016-2018, Pulumi Corporation.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package cmd
import (
"context"
"fmt"
"io/ioutil"
"math"
"os"
"github.com/pulumi/pulumi/pkg/tokens"
"github.com/pulumi/pulumi/pkg/util/contract"
"github.com/pkg/errors"
"github.com/spf13/cobra"
"github.com/pulumi/pulumi/pkg/backend"
"github.com/pulumi/pulumi/pkg/backend/display"
"github.com/pulumi/pulumi/pkg/engine"
"github.com/pulumi/pulumi/pkg/resource/config"
"github.com/pulumi/pulumi/pkg/resource/deploy"
"github.com/pulumi/pulumi/pkg/resource/stack"
"github.com/pulumi/pulumi/pkg/util/cmdutil"
"github.com/pulumi/pulumi/pkg/util/result"
"github.com/pulumi/pulumi/pkg/workspace"
)
const (
defaultParallel = math.MaxInt32
)
// intentionally disabling here for cleaner err declaration/assignment.
// nolint: vetshadow
func newUpCmd() *cobra.Command {
var debug bool
var expectNop bool
var message string
var stack string
var configArray []string
// Flags for engine.UpdateOptions.
var analyzers []string
var diffDisplay bool
var parallel int
var refresh bool
var showConfig bool
var showReplacementSteps bool
var showSames bool
var skipPreview bool
var suppressOutputs bool
var yes bool
var secretsProvider string
// up implementation used when the source of the Pulumi program is in the current working directory.
upWorkingDirectory := func(opts backend.UpdateOptions) result.Result {
s, err := requireStack(stack, true, opts.Display, true /*setCurrent*/)
if err != nil {
return result.FromError(err)
}
// Save any config values passed via flags.
if len(configArray) > 0 {
commandLineConfig, err := parseConfig(configArray)
if err != nil {
return result.FromError(err)
}
if err = saveConfig(s, commandLineConfig); err != nil {
return result.FromError(errors.Wrap(err, "saving config"))
}
}
proj, root, err := readProject()
if err != nil {
return result.FromError(err)
}
m, err := getUpdateMetadata(message, root)
if err != nil {
return result.FromError(errors.Wrap(err, "gathering environment metadata"))
}
sm, err := getStackSecretsManager(s)
if err != nil {
return result.FromError(errors.Wrap(err, "getting secrets manager"))
}
cfg, err := getStackConfiguration(s, sm)
if err != nil {
return result.FromError(errors.Wrap(err, "getting stack configuration"))
}
opts.Engine = engine.UpdateOptions{
Analyzers: analyzers,
Parallel: parallel,
Debug: debug,
Refresh: refresh,
UseLegacyDiff: useLegacyDiff(),
}
changes, res := s.Update(commandContext(), backend.UpdateOperation{
Proj: proj,
Root: root,
M: m,
Opts: opts,
StackConfiguration: cfg,
SecretsManager: sm,
Scopes: cancellationScopes,
})
switch {
case res != nil && res.Error() == context.Canceled:
return result.FromError(errors.New("update cancelled"))
case res != nil:
return PrintEngineResult(res)
case expectNop && changes != nil && changes.HasChanges():
return result.FromError(errors.New("error: no changes were expected but changes occurred"))
default:
return nil
}
}
// up implementation used when the source of the Pulumi program is a template name or a URL to a template.
upTemplateNameOrURL := func(templateNameOrURL string, opts backend.UpdateOptions) result.Result {
// Retrieve the template repo.
repo, err := workspace.RetrieveTemplates(templateNameOrURL, false)
if err != nil {
return result.FromError(err)
}
defer func() {
contract.IgnoreError(repo.Delete())
}()
// List the templates from the repo.
templates, err := repo.Templates()
if err != nil {
return result.FromError(err)
}
var template workspace.Template
if len(templates) == 0 {
return result.FromError(errors.New("no template found"))
} else if len(templates) == 1 {
template = templates[0]
} else {
if template, err = chooseTemplate(templates, opts.Display); err != nil {
return result.FromError(err)
}
}
// Validate secrets provider type
if err := validateSecretsProvider(secretsProvider); err != nil {
return result.FromError(err)
}
// Create temp directory for the "virtual workspace".
temp, err := ioutil.TempDir("", "pulumi-up-")
if err != nil {
return result.FromError(err)
}
defer func() {
contract.IgnoreError(os.RemoveAll(temp))
}()
// Change the working directory to the "virtual workspace" directory.
if err = os.Chdir(temp); err != nil {
return result.FromError(errors.Wrap(err, "changing the working directory"))
}
// If a stack was specified via --stack, see if it already exists.
var name string
var description string
var s backend.Stack
if stack != "" {
if s, name, description, err = getStack(stack, opts.Display); err != nil {
return result.FromError(err)
}
}
// Prompt for the project name, if we don't already have one from an existing stack.
if name == "" {
defaultValue := workspace.ValueOrSanitizedDefaultProjectName(name, template.ProjectName, template.Name)
name, err = promptForValue(
yes, "project name", defaultValue, false, workspace.ValidateProjectName, opts.Display)
if err != nil {
return result.FromError(err)
}
}
// Prompt for the project description, if we don't already have one from an existing stack.
if description == "" {
defaultValue := workspace.ValueOrDefaultProjectDescription(
description, template.ProjectDescription, template.Description)
description, err = promptForValue(
yes, "project description", defaultValue, false, workspace.ValidateProjectDescription, opts.Display)
if err != nil {
return result.FromError(err)
}
}
// Copy the template files from the repo to the temporary "virtual workspace" directory.
if err = template.CopyTemplateFiles(temp, true, name, description); err != nil {
return result.FromError(err)
}
// Load the project, update the name & description, remove the template section, and save it.
proj, root, err := readProject()
if err != nil {
return result.FromError(err)
}
proj.Name = tokens.PackageName(name)
proj.Description = &description
proj.Template = nil
if err = workspace.SaveProject(proj); err != nil {
return result.FromError(errors.Wrap(err, "saving project"))
}
// Create the stack, if needed.
if s == nil {
if s, err = promptAndCreateStack(stack, name, false /*setCurrent*/, yes,
opts.Display, secretsProvider); err != nil {
return result.FromError(err)
}
// The backend will print "Created stack '<stack>'." on success.
}
// Prompt for config values (if needed) and save.
if err = handleConfig(s, templateNameOrURL, template, configArray, yes, opts.Display); err != nil {
return result.FromError(err)
}
// Install dependencies.
if err = installDependencies(); err != nil {
return result.FromError(err)
}
m, err := getUpdateMetadata(message, root)
if err != nil {
return result.FromError(errors.Wrap(err, "gathering environment metadata"))
}
sm, err := getStackSecretsManager(s)
if err != nil {
return result.FromError(errors.Wrap(err, "getting secrets manager"))
}
cfg, err := getStackConfiguration(s, sm)
if err != nil {
return result.FromError(errors.Wrap(err, "getting stack configuration"))
}
opts.Engine = engine.UpdateOptions{
Analyzers: analyzers,
Parallel: parallel,
Debug: debug,
Refresh: refresh,
}
// TODO for the URL case:
// - suppress preview display/prompt unless error.
// - attempt `destroy` on any update errors.
// - show template.Quickstart?
changes, res := s.Update(commandContext(), backend.UpdateOperation{
Proj: proj,
Root: root,
M: m,
Opts: opts,
StackConfiguration: cfg,
SecretsManager: sm,
Scopes: cancellationScopes,
})
switch {
case res != nil && res.Error() == context.Canceled:
return result.FromError(errors.New("update cancelled"))
case res != nil:
return PrintEngineResult(res)
case expectNop && changes != nil && changes.HasChanges():
return result.FromError(errors.New("error: no changes were expected but changes occurred"))
default:
return nil
}
}
var cmd = &cobra.Command{
Use: "up [template|url]",
Aliases: []string{"update"},
SuggestFor: []string{"apply", "deploy", "push"},
Short: "Create or update the resources in a stack",
Long: "Create or update the resources in a stack.\n" +
"\n" +
"This command creates or updates resources in a stack. The new desired goal state for the target stack\n" +
"is computed by running the current Pulumi program and observing all resource allocations to produce a\n" +
"resource graph. This goal state is then compared against the existing state to determine what create,\n" +
"read, update, and/or delete operations must take place to achieve the desired goal state, in the most\n" +
"minimally disruptive way. This command records a full transactional snapshot of the stack's new state\n" +
"afterwards so that the stack may be updated incrementally again later on.\n" +
"\n" +
"The program to run is loaded from the project in the current directory by default. Use the `-C` or\n" +
"`--cwd` flag to use a different directory.",
Args: cmdutil.MaximumNArgs(1),
Run: cmdutil.RunResultFunc(func(cmd *cobra.Command, args []string) result.Result {
interactive := cmdutil.Interactive()
if !interactive {
yes = true // auto-approve changes, since we cannot prompt.
}
opts, err := updateFlagsToOptions(interactive, skipPreview, yes)
if err != nil {
return result.FromError(err)
}
var displayType = display.DisplayProgress
if diffDisplay {
displayType = display.DisplayDiff
}
opts.Display = display.Options{
Color: cmdutil.GetGlobalColorization(),
ShowConfig: showConfig,
ShowReplacementSteps: showReplacementSteps,
ShowSameResources: showSames,
SuppressOutputs: suppressOutputs,
IsInteractive: interactive,
Type: displayType,
Debug: debug,
}
if len(args) > 0 {
return upTemplateNameOrURL(args[0], opts)
}
return upWorkingDirectory(opts)
}),
}
cmd.PersistentFlags().BoolVarP(
&debug, "debug", "d", false,
"Print detailed debugging output during resource operations")
cmd.PersistentFlags().BoolVar(
&expectNop, "expect-no-changes", false,
"Return an error if any changes occur during this update")
cmd.PersistentFlags().StringVarP(
&stack, "stack", "s", "",
"The name of the stack to operate on. Defaults to the current stack")
cmd.PersistentFlags().StringVar(
&stackConfigFile, "config-file", "",
"Use the configuration values in the specified file rather than detecting the file name")
cmd.PersistentFlags().StringArrayVarP(
&configArray, "config", "c", []string{},
"Config to use during the update")
cmd.PersistentFlags().StringVar(
&secretsProvider, "secrets-provider", "default", "The type of the provider that should be used to encrypt and "+
"decrypt secrets (possible choices: default, passphrase). Only used when creating a new stack from "+
"an existing template")
cmd.PersistentFlags().StringVarP(
&message, "message", "m", "",
"Optional message to associate with the update operation")
// Flags for engine.UpdateOptions.
cmd.PersistentFlags().StringSliceVar(
&analyzers, "analyzer", []string{},
"Run one or more analyzers as part of this update")
cmd.PersistentFlags().BoolVar(
&diffDisplay, "diff", false,
"Display operation as a rich diff showing the overall change")
cmd.PersistentFlags().IntVarP(
&parallel, "parallel", "p", defaultParallel,
"Allow P resource operations to run in parallel at once (1 for no parallelism). Defaults to unbounded.")
cmd.PersistentFlags().BoolVarP(
&refresh, "refresh", "r", false,
"Refresh the state of the stack's resources before this update")
cmd.PersistentFlags().BoolVar(
&showConfig, "show-config", false,
"Show configuration keys and variables")
cmd.PersistentFlags().BoolVar(
&showReplacementSteps, "show-replacement-steps", false,
"Show detailed resource replacement creates and deletes instead of a single step")
cmd.PersistentFlags().BoolVar(
&showSames, "show-sames", false,
"Show resources that don't need be updated because they haven't changed, alongside those that do")
cmd.PersistentFlags().BoolVar(
&skipPreview, "skip-preview", false,
"Do not perform a preview before performing the update")
cmd.PersistentFlags().BoolVar(
&suppressOutputs, "suppress-outputs", false,
"Suppress display of stack outputs (in case they contain sensitive values)")
cmd.PersistentFlags().BoolVarP(
&yes, "yes", "y", false,
"Automatically approve and perform the update after previewing it")
return cmd
}
// handleConfig handles prompting for config values (as needed) and saving config.
func handleConfig(
s backend.Stack,
templateNameOrURL string,
template workspace.Template,
configArray []string,
yes bool,
opts display.Options) error {
// Get the existing config. stackConfig will be nil if there wasn't a previous deployment.
stackConfig, err := backend.GetLatestConfiguration(commandContext(), s)
if err != nil && err != backend.ErrNoPreviousDeployment {
return err
}
// Get the existing snapshot.
snap, err := s.Snapshot(commandContext())
if err != nil {
return err
}
// Handle config.
// If this is an initial preconfigured empty stack (i.e. configured in the Pulumi Console),
// use its config without prompting.
// Otherwise, use the values specified on the command line and prompt for new values.
// If the stack already existed and had previous config, those values will be used as the defaults.
var c config.Map
if isPreconfiguredEmptyStack(templateNameOrURL, template.Config, stackConfig, snap) {
c = stackConfig
// TODO[pulumi/pulumi#1894] consider warning if templateNameOrURL is different from
// the stack's `pulumi:template` config value.
} else {
// Get config values passed on the command line.
commandLineConfig, parseErr := parseConfig(configArray)
if parseErr != nil {
return parseErr
}
// Prompt for config as needed.
c, err = promptForConfig(s, template.Config, commandLineConfig, stackConfig, yes, opts)
if err != nil {
return err
}
}
// Save the config.
if len(c) > 0 {
if err = saveConfig(s, c); err != nil {
return errors.Wrap(err, "saving config")
}
fmt.Println("Saved config")
fmt.Println()
}
return nil
}
var (
templateKey = config.MustMakeKey("pulumi", "template")
)
// isPreconfiguredEmptyStack returns true if the url matches the value of `pulumi:template` in stackConfig,
// the stackConfig values satisfy the config requirements of templateConfig, and the snapshot is empty.
// This is the state of an initial preconfigured empty stack (i.e. a stack that's been created and configured
// in the Pulumi Console).
func isPreconfiguredEmptyStack(
url string,
templateConfig map[string]workspace.ProjectTemplateConfigValue,
stackConfig config.Map,
snap *deploy.Snapshot) bool {
// Does stackConfig have a `pulumi:template` value and does it match url?
if stackConfig == nil {
return false
}
templateURLValue, hasTemplateKey := stackConfig[templateKey]
if !hasTemplateKey {
return false
}
templateURL, err := templateURLValue.Value(nil)
if err != nil {
contract.IgnoreError(err)
return false
}
if templateURL != url {
return false
}
// Does the snapshot only contain a single root resource?
if len(snap.Resources) != 1 {
return false
}
stackResource, err := stack.GetRootStackResource(snap)
if err != nil || stackResource == nil {
return false
}
// Can stackConfig satisfy the config requirements of templateConfig?
for templateKey, templateVal := range templateConfig {
parsedTemplateKey, parseErr := parseConfigKey(templateKey)
if parseErr != nil {
contract.IgnoreError(parseErr)
return false
}
stackVal, ok := stackConfig[parsedTemplateKey]
if !ok {
return false
}
if templateVal.Secret != stackVal.Secure() {
return false
}
}
return true
}