pulumi/pkg/util/httputil/http.go
Pat Gavlin 78aaa29cee
Fix httputil.DoWithRetry. (#1555)
If we've hit the maximum number of retry attempts, return `true` for
`done`. As it stands, it is possible for us to return a `nil` error
(e.g. if the request sends successfully but returns a `50x` status) and
`false` for `done`, which `retry.Until` will interpret as "keep
retrying".
2018-06-21 11:06:54 -07:00

82 lines
2.4 KiB
Go

// Copyright 2016-2018, Pulumi Corporation.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package httputil
import (
"context"
"net/http"
"time"
"github.com/pulumi/pulumi/pkg/util/contract"
"github.com/pulumi/pulumi/pkg/util/retry"
)
// maxRetryCount is the number of times to try an http request before giving up an returning the last error
const maxRetryCount = 5
// DoWithRetry calls client.Do, and in the case of an error, retries the operation again after a slight delay.
func DoWithRetry(req *http.Request, client *http.Client) (*http.Response, error) {
contract.Assertf(req.ContentLength == 0 || req.GetBody != nil,
"Retryable request must have no body or rewindable body")
inRange := func(test, lower, upper int) bool {
return lower <= test && test <= upper
}
_, res, err := retry.Until(context.Background(), retry.Acceptor{
Accept: func(try int, nextRetryTime time.Duration) (bool, interface{}, error) {
if try > 0 && req.GetBody != nil {
// Reset request body, if present, for retries.
rc, bodyErr := req.GetBody()
if bodyErr != nil {
return false, nil, bodyErr
}
req.Body = rc
}
res, resErr := client.Do(req)
if resErr == nil && !inRange(res.StatusCode, 500, 599) {
return true, res, nil
}
if try >= (maxRetryCount - 1) {
return true, res, resErr
}
// Close the response body, if present, since our caller can't.
if resErr == nil {
contract.IgnoreError(res.Body.Close())
}
return false, nil, nil
},
})
if err != nil {
return nil, err
}
return res.(*http.Response), nil
}
// GetWithRetry issues a GET request with the given client, and in the case of an error, retries the operation again
// after a slight delay.
func GetWithRetry(url string, client *http.Client) (*http.Response, error) {
req, err := http.NewRequest("GET", url, nil)
if err != nil {
return nil, err
}
return DoWithRetry(req, client)
}