pulumi/pkg/engine/diff.go
Pat Gavlin a222705143
Implement first-class providers. (#1695)
### First-Class Providers
These changes implement support for first-class providers. First-class
providers are provider plugins that are exposed as resources via the
Pulumi programming model so that they may be explicitly and multiply
instantiated. Each instance of a provider resource may be configured
differently, and configuration parameters may be source from the
outputs of other resources.

### Provider Plugin Changes
In order to accommodate the need to verify and diff provider
configuration and configure providers without complete configuration
information, these changes adjust the high-level provider plugin
interface. Two new methods for validating a provider's configuration
and diffing changes to the same have been added (`CheckConfig` and
`DiffConfig`, respectively), and the type of the configuration bag
accepted by `Configure` has been changed to a `PropertyMap`.

These changes have not yet been reflected in the provider plugin gRPC
interface. We will do this in a set of follow-up changes. Until then,
these methods are implemented by adapters:
- `CheckConfig` validates that all configuration parameters are string
  or unknown properties. This is necessary because existing plugins
  only accept string-typed configuration values.
- `DiffConfig` either returns "never replace" if all configuration
  values are known or "must replace" if any configuration value is
  unknown. The justification for this behavior is given
  [here](https://github.com/pulumi/pulumi/pull/1695/files#diff-a6cd5c7f337665f5bb22e92ca5f07537R106)
- `Configure` converts the config bag to a legacy config map and
  configures the provider plugin if all config values are known. If any
  config value is unknown, the underlying plugin is not configured and
  the provider may only perform `Check`, `Read`, and `Invoke`, all of
  which return empty results. We justify this behavior becuase it is
  only possible during a preview and provides the best experience we
  can manage with the existing gRPC interface.

### Resource Model Changes
Providers are now exposed as resources that participate in a stack's
dependency graph. Like other resources, they are explicitly created,
may have multiple instances, and may have dependencies on other
resources. Providers are referred to using provider references, which
are a combination of the provider's URN and its ID. This design
addresses the need during a preview to refer to providers that have not
yet been physically created and therefore have no ID.

All custom resources that are not themselves providers must specify a
single provider via a provider reference. The named provider will be
used to manage that resource's CRUD operations. If a resource's
provider reference changes, the resource must be replaced. Though its
URN is not present in the resource's dependency list, the provider
should be treated as a dependency of the resource when topologically
sorting the dependency graph.

Finally, `Invoke` operations must now specify a provider to use for the
invocation via a provider reference.

### Engine Changes
First-class providers support requires a few changes to the engine:
- The engine must have some way to map from provider references to
  provider plugins. It must be possible to add providers from a stack's
  checkpoint to this map and to register new/updated providers during
  the execution of a plan in response to CRUD operations on provider
  resources.
- In order to support updating existing stacks using existing Pulumi
  programs that may not explicitly instantiate providers, the engine
  must be able to manage the "default" providers for each package
  referenced by a checkpoint or Pulumi program. The configuration for
  a "default" provider is taken from the stack's configuration data.

The former need is addressed by adding a provider registry type that is
responsible for managing all of the plugins required by a plan. In
addition to loading plugins froma checkpoint and providing the ability
to map from a provider reference to a provider plugin, this type serves
as the provider plugin for providers themselves (i.e. it is the
"provider provider").

The latter need is solved via two relatively self-contained changes to
plan setup and the eval source.

During plan setup, the old checkpoint is scanned for custom resources
that do not have a provider reference in order to compute the set of
packages that require a default provider. Once this set has been
computed, the required default provider definitions are conjured and
prepended to the checkpoint's resource list. Each resource that
requires a default provider is then updated to refer to the default
provider for its package.

While an eval source is running, each custom resource registration,
resource read, and invoke that does not name a provider is trapped
before being returned by the source iterator. If no default provider
for the appropriate package has been registered, the eval source
synthesizes an appropriate registration, waits for it to complete, and
records the registered provider's reference. This reference is injected
into the original request, which is then processed as usual. If a
default provider was already registered, the recorded reference is
used and no new registration occurs.

### SDK Changes
These changes only expose first-class providers from the Node.JS SDK.
- A new abstract class, `ProviderResource`, can be subclassed and used
  to instantiate first-class providers.
- A new field in `ResourceOptions`, `provider`, can be used to supply
  a particular provider instance to manage a `CustomResource`'s CRUD
  operations.
- A new type, `InvokeOptions`, can be used to specify options that
  control the behavior of a call to `pulumi.runtime.invoke`. This type
  includes a `provider` field that is analogous to
  `ResourceOptions.provider`.
2018-08-06 17:50:29 -07:00

907 lines
28 KiB
Go

// Copyright 2016-2018, Pulumi Corporation.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package engine
import (
"bytes"
"fmt"
"reflect"
"sort"
"strconv"
"strings"
"github.com/sergi/go-diff/diffmatchpatch"
"github.com/pulumi/pulumi/pkg/diag/colors"
"github.com/pulumi/pulumi/pkg/resource"
"github.com/pulumi/pulumi/pkg/resource/deploy"
"github.com/pulumi/pulumi/pkg/resource/deploy/providers"
"github.com/pulumi/pulumi/pkg/util/contract"
)
// GetIndent computes a step's parent indentation.
func GetIndent(step StepEventMetadata, seen map[resource.URN]StepEventMetadata) int {
indent := 0
for p := step.Res.Parent; p != ""; {
if par, has := seen[p]; !has {
// This can happen during deletes, since we delete children before parents.
// TODO[pulumi/pulumi#340]: we need to figure out how best to display this sequence; at the very
// least, it would be ideal to preserve the indentation.
break
} else {
indent++
p = par.Res.Parent
}
}
return indent
}
func printStepHeader(b *bytes.Buffer, step StepEventMetadata) {
var extra string
old := step.Old
new := step.New
if new != nil && !new.Protect && old != nil && old.Protect {
// show an unlocked symbol, since we are unprotecting a resource.
extra = " 🔓"
} else if (new != nil && new.Protect) || (old != nil && old.Protect) {
// show a locked symbol, since we are either newly protecting this resource, or retaining protection.
extra = " 🔒"
}
writeString(b, fmt.Sprintf("%s: (%s)%s\n", string(step.Type), step.Op, extra))
}
func getIndentationString(indent int, op deploy.StepOp, prefix bool) string {
var result string
for i := 0; i < indent; i++ {
result += " "
}
if result == "" {
contract.Assertf(!prefix, "Expected indention for a prefixed line")
return result
}
var rp string
if prefix {
rp = op.RawPrefix()
} else {
rp = " "
}
contract.Assert(len(rp) == 2)
contract.Assert(len(result) >= 2)
return result[:len(result)-2] + rp
}
func writeString(b *bytes.Buffer, s string) {
_, err := b.WriteString(s)
contract.IgnoreError(err)
}
func writeWithIndent(b *bytes.Buffer, indent int, op deploy.StepOp, prefix bool, format string, a ...interface{}) {
writeString(b, op.Color())
writeString(b, getIndentationString(indent, op, prefix))
writeString(b, fmt.Sprintf(format, a...))
writeString(b, colors.Reset)
}
func writeWithIndentNoPrefix(b *bytes.Buffer, indent int, op deploy.StepOp, format string, a ...interface{}) {
writeWithIndent(b, indent, op, false, format, a...)
}
func write(b *bytes.Buffer, op deploy.StepOp, format string, a ...interface{}) {
writeWithIndentNoPrefix(b, 0, op, format, a...)
}
func writeVerbatim(b *bytes.Buffer, op deploy.StepOp, value string) {
writeWithIndentNoPrefix(b, 0, op, "%s", value)
}
func GetResourcePropertiesSummary(step StepEventMetadata, indent int) string {
var b bytes.Buffer
op := step.Op
urn := step.URN
old := step.Old
// Print the indentation.
writeString(&b, getIndentationString(indent, op, false))
// First, print out the operation's prefix.
writeString(&b, op.Prefix())
// Next, print the resource type (since it is easy on the eyes and can be quickly identified).
printStepHeader(&b, step)
// For these simple properties, print them as 'same' if they're just an update or replace.
simplePropOp := considerSameIfNotCreateOrDelete(op)
// Print out the URN and, if present, the ID, as "pseudo-properties" and indent them.
var id resource.ID
if old != nil {
id = old.ID
}
// Always print the ID, URN, and provider.
if id != "" {
writeWithIndentNoPrefix(&b, indent+1, simplePropOp, "[id=%s]\n", string(id))
}
if urn != "" {
writeWithIndentNoPrefix(&b, indent+1, simplePropOp, "[urn=%s]\n", urn)
}
if step.Provider != "" {
new := step.New
if old != nil && new != nil && old.Provider != new.Provider {
newProv, err := providers.ParseReference(new.Provider)
contract.Assert(err == nil)
writeWithIndentNoPrefix(&b, indent+1, deploy.OpUpdate, "[provider: ")
write(&b, deploy.OpDelete, "%s", old.Provider)
writeVerbatim(&b, deploy.OpUpdate, " => ")
if newProv.ID() == providers.UnknownID {
write(&b, deploy.OpCreate, "%s", string(newProv.URN())+"::computed<string>")
} else {
write(&b, deploy.OpCreate, "%s", new.Provider)
}
writeVerbatim(&b, deploy.OpUpdate, "]\n")
} else {
writeWithIndentNoPrefix(&b, indent+1, simplePropOp, "[provider=%s]\n", step.Provider)
}
}
return b.String()
}
func GetResourcePropertiesDetails(
step StepEventMetadata, indent int, planning bool, summary bool, debug bool) string {
var b bytes.Buffer
// indent everything an additional level, like other properties.
indent++
var replaces []resource.PropertyKey
if step.Op == deploy.OpCreateReplacement || step.Op == deploy.OpReplace {
replaces = step.Keys
}
old, new := step.Old, step.New
if old == nil && new != nil {
if len(new.Outputs) > 0 {
printObject(&b, new.Outputs, planning, indent, step.Op, false, debug)
} else {
printObject(&b, new.Inputs, planning, indent, step.Op, false, debug)
}
} else if new == nil && old != nil {
// in summary view, we don't have to print out the entire object that is getting deleted.
// note, the caller will have already printed out the type/name/id/urn of the resource,
// and that's sufficient for a summarized deletion view.
if !summary {
printObject(&b, old.Inputs, planning, indent, step.Op, false, debug)
}
} else if len(new.Outputs) > 0 {
printOldNewDiffs(&b, old.Outputs, new.Outputs, replaces, planning, indent, step.Op, summary, debug)
} else {
printOldNewDiffs(&b, old.Inputs, new.Inputs, replaces, planning, indent, step.Op, summary, debug)
}
return b.String()
}
func maxKey(keys []resource.PropertyKey) int {
maxkey := 0
for _, k := range keys {
if len(k) > maxkey {
maxkey = len(k)
}
}
return maxkey
}
func printObject(
b *bytes.Buffer, props resource.PropertyMap, planning bool,
indent int, op deploy.StepOp, prefix bool, debug bool) {
// Compute the maximum with of property keys so we can justify everything.
keys := props.StableKeys()
maxkey := maxKey(keys)
// Now print out the values intelligently based on the type.
for _, k := range keys {
if v := props[k]; shouldPrintPropertyValue(v, planning) {
printPropertyTitle(b, string(k), maxkey, indent, op, prefix)
printPropertyValue(b, v, planning, indent, op, prefix, debug)
}
}
}
// GetResourceOutputsPropertiesString prints only those properties that either differ from the input properties or, if
// there is an old snapshot of the resource, differ from the prior old snapshot's output properties.
func GetResourceOutputsPropertiesString(
step StepEventMetadata, indent int, planning bool, debug bool) string {
var b bytes.Buffer
// Only certain kinds of steps have output properties associated with them.
new := step.New
if new == nil || new.Outputs == nil {
return ""
}
op := considerSameIfNotCreateOrDelete(step.Op)
// First fetch all the relevant property maps that we may consult.
ins := new.Inputs
outs := new.Outputs
// Now sort the keys and enumerate each output property in a deterministic order.
firstout := true
keys := outs.StableKeys()
maxkey := maxKey(keys)
for _, k := range keys {
out := outs[k]
// Print this property if it is printable and either ins doesn't have it or it's different.
if shouldPrintPropertyValue(out, true) {
var print bool
if in, has := ins[k]; has {
print = (out.Diff(in) != nil)
} else {
print = true
}
if print {
if firstout {
writeWithIndentNoPrefix(&b, indent, op, "---outputs:---\n")
firstout = false
}
printPropertyTitle(&b, string(k), maxkey, indent, op, false)
printPropertyValue(&b, out, planning, indent, op, false, debug)
}
}
}
return b.String()
}
func considerSameIfNotCreateOrDelete(op deploy.StepOp) deploy.StepOp {
if op == deploy.OpCreate || op == deploy.OpDelete || op == deploy.OpDeleteReplaced {
return op
}
return deploy.OpSame
}
func shouldPrintPropertyValue(v resource.PropertyValue, outs bool) bool {
if v.IsNull() {
return false // don't print nulls (they just clutter up the output).
}
if v.IsString() && v.StringValue() == "" {
return false // don't print empty strings either.
}
if v.IsArray() && len(v.ArrayValue()) == 0 {
return false // skip empty arrays, since they are often uninteresting default values.
}
if v.IsObject() && len(v.ObjectValue()) == 0 {
return false // skip objects with no properties, since they are also uninteresting.
}
if v.IsObject() && len(v.ObjectValue()) == 0 {
return false // skip objects with no properties, since they are also uninteresting.
}
if v.IsOutput() && !outs {
// also don't show output properties until the outs parameter tells us to.
return false
}
return true
}
func printPropertyTitle(b *bytes.Buffer, name string, align int, indent int, op deploy.StepOp, prefix bool) {
writeWithIndent(b, indent, op, prefix, "%-"+strconv.Itoa(align)+"s: ", name)
}
func printPropertyValue(
b *bytes.Buffer, v resource.PropertyValue, planning bool,
indent int, op deploy.StepOp, prefix bool, debug bool) {
if isPrimitive(v) {
printPrimitivePropertyValue(b, v, planning, op)
} else if v.IsArray() {
arr := v.ArrayValue()
if len(arr) == 0 {
writeVerbatim(b, op, "[]")
} else {
writeVerbatim(b, op, "[\n")
for i, elem := range arr {
writeWithIndent(b, indent, op, prefix, " [%d]: ", i)
printPropertyValue(b, elem, planning, indent+1, op, prefix, debug)
}
writeWithIndentNoPrefix(b, indent, op, "]")
}
} else if v.IsAsset() {
a := v.AssetValue()
if a.IsText() {
write(b, op, "asset(text:%s) {\n", shortHash(a.Hash))
a = resource.MassageIfUserProgramCodeAsset(a, debug)
massaged := a.Text
// pretty print the text, line by line, with proper breaks.
lines := strings.Split(massaged, "\n")
for _, line := range lines {
writeWithIndentNoPrefix(b, indent, op, " %s\n", line)
}
writeWithIndentNoPrefix(b, indent, op, "}")
} else if path, has := a.GetPath(); has {
write(b, op, "asset(file:%s) { %s }", shortHash(a.Hash), path)
} else {
contract.Assert(a.IsURI())
write(b, op, "asset(uri:%s) { %s }", shortHash(a.Hash), a.URI)
}
} else if v.IsArchive() {
a := v.ArchiveValue()
if assets, has := a.GetAssets(); has {
write(b, op, "archive(assets:%s) {\n", shortHash(a.Hash))
var names []string
for name := range assets {
names = append(names, name)
}
sort.Strings(names)
for _, name := range names {
printAssetOrArchive(b, assets[name], name, planning, indent, op, prefix, debug)
}
writeWithIndentNoPrefix(b, indent, op, "}")
} else if path, has := a.GetPath(); has {
write(b, op, "archive(file:%s) { %s }", shortHash(a.Hash), path)
} else {
contract.Assert(a.IsURI())
write(b, op, "archive(uri:%s) { %v }", shortHash(a.Hash), a.URI)
}
} else {
contract.Assert(v.IsObject())
obj := v.ObjectValue()
if len(obj) == 0 {
writeVerbatim(b, op, "{}")
} else {
writeVerbatim(b, op, "{\n")
printObject(b, obj, planning, indent+1, op, prefix, debug)
writeWithIndentNoPrefix(b, indent, op, "}")
}
}
writeVerbatim(b, op, "\n")
}
func printAssetOrArchive(
b *bytes.Buffer, v interface{}, name string, planning bool,
indent int, op deploy.StepOp, prefix bool, debug bool) {
writeWithIndent(b, indent, op, prefix, " \"%v\": ", name)
printPropertyValue(b, assetOrArchiveToPropertyValue(v), planning, indent+1, op, prefix, debug)
}
func assetOrArchiveToPropertyValue(v interface{}) resource.PropertyValue {
switch t := v.(type) {
case *resource.Asset:
return resource.NewAssetProperty(t)
case *resource.Archive:
return resource.NewArchiveProperty(t)
default:
contract.Failf("Unexpected archive element '%v'", reflect.TypeOf(t))
return resource.PropertyValue{V: nil}
}
}
func shortHash(hash string) string {
if len(hash) > 7 {
return hash[:7]
}
return hash
}
func printOldNewDiffs(
b *bytes.Buffer, olds resource.PropertyMap, news resource.PropertyMap,
replaces []resource.PropertyKey, planning bool, indent int, op deploy.StepOp,
summary bool, debug bool) {
// Get the full diff structure between the two, and print it (recursively).
if diff := olds.Diff(news); diff != nil {
printObjectDiff(b, *diff, replaces, false, planning, indent, summary, debug)
} else {
printObject(b, news, planning, indent, op, true, debug)
}
}
func printObjectDiff(b *bytes.Buffer, diff resource.ObjectDiff,
replaces []resource.PropertyKey, causedReplace bool, planning bool,
indent int, summary bool, debug bool) {
contract.Assert(indent > 0)
// Compute the maximum with of property keys so we can justify everything.
keys := diff.Keys()
maxkey := maxKey(keys)
// If a list of what causes a resource to get replaced exist, create a handy map.
var replaceMap map[resource.PropertyKey]bool
if len(replaces) > 0 {
replaceMap = make(map[resource.PropertyKey]bool)
for _, k := range replaces {
replaceMap[k] = true
}
}
// To print an object diff, enumerate the keys in stable order, and print each property independently.
for _, k := range keys {
titleFunc := func(top deploy.StepOp, prefix bool) {
printPropertyTitle(b, string(k), maxkey, indent, top, prefix)
}
if add, isadd := diff.Adds[k]; isadd {
if shouldPrintPropertyValue(add, planning) {
printAdd(b, add, titleFunc, planning, indent, debug)
}
} else if delete, isdelete := diff.Deletes[k]; isdelete {
if shouldPrintPropertyValue(delete, planning) {
printDelete(b, delete, titleFunc, planning, indent, debug)
}
} else if update, isupdate := diff.Updates[k]; isupdate {
if !causedReplace && replaceMap != nil {
causedReplace = replaceMap[k]
}
printPropertyValueDiff(
b, titleFunc, update, causedReplace, planning,
indent, summary, debug)
} else if same := diff.Sames[k]; !summary && shouldPrintPropertyValue(same, planning) {
titleFunc(deploy.OpSame, false)
printPropertyValue(b, diff.Sames[k], planning, indent, deploy.OpSame, false, debug)
}
}
}
func printPropertyValueDiff(
b *bytes.Buffer, titleFunc func(deploy.StepOp, bool),
diff resource.ValueDiff, causedReplace bool, planning bool,
indent int, summary bool, debug bool) {
op := deploy.OpUpdate
contract.Assert(indent > 0)
if diff.Array != nil {
titleFunc(op, true)
writeVerbatim(b, op, "[\n")
a := diff.Array
for i := 0; i < a.Len(); i++ {
elemTitleFunc := func(eop deploy.StepOp, eprefix bool) {
writeWithIndent(b, indent+1, eop, eprefix, "[%d]: ", i)
}
if add, isadd := a.Adds[i]; isadd {
printAdd(b, add, elemTitleFunc, planning, indent+2, debug)
} else if delete, isdelete := a.Deletes[i]; isdelete {
printDelete(b, delete, elemTitleFunc, planning, indent+2, debug)
} else if update, isupdate := a.Updates[i]; isupdate {
printPropertyValueDiff(
b, elemTitleFunc, update, causedReplace, planning,
indent+2, summary, debug)
} else if !summary {
elemTitleFunc(deploy.OpSame, false)
printPropertyValue(b, a.Sames[i], planning, indent+2, deploy.OpSame, false, debug)
}
}
writeWithIndentNoPrefix(b, indent, op, "]\n")
} else if diff.Object != nil {
titleFunc(op, true)
writeVerbatim(b, op, "{\n")
printObjectDiff(b, *diff.Object, nil, causedReplace, planning, indent+1, summary, debug)
writeWithIndentNoPrefix(b, indent, op, "}\n")
} else {
shouldPrintOld := shouldPrintPropertyValue(diff.Old, false)
shouldPrintNew := shouldPrintPropertyValue(diff.New, false)
if shouldPrintOld && shouldPrintNew {
if diff.Old.IsArchive() &&
diff.New.IsArchive() &&
!causedReplace {
printArchiveDiff(
b, titleFunc, diff.Old.ArchiveValue(), diff.New.ArchiveValue(),
planning, indent, summary, debug)
return
}
if isPrimitive(diff.Old) && isPrimitive(diff.New) {
titleFunc(deploy.OpUpdate, true /*indent*/)
printPrimitivePropertyValue(b, diff.Old, planning, deploy.OpDelete)
writeVerbatim(b, deploy.OpUpdate, " => ")
printPrimitivePropertyValue(b, diff.New, planning, deploy.OpCreate)
writeVerbatim(b, deploy.OpUpdate, "\n")
return
}
}
// If we ended up here, the two values either differ by type, or they have different primitive values. We will
// simply emit a deletion line followed by an addition line.
if shouldPrintOld {
printDelete(b, diff.Old, titleFunc, planning, indent, debug)
}
if shouldPrintNew {
printAdd(b, diff.New, titleFunc, planning, indent, debug)
}
}
}
func isPrimitive(value resource.PropertyValue) bool {
return value.IsNull() || value.IsString() || value.IsNumber() ||
value.IsBool() || value.IsComputed() || value.IsOutput()
}
func printPrimitivePropertyValue(b *bytes.Buffer, v resource.PropertyValue, planning bool, op deploy.StepOp) {
contract.Assert(isPrimitive(v))
if v.IsNull() {
writeVerbatim(b, op, "<null>")
} else if v.IsBool() {
write(b, op, "%t", v.BoolValue())
} else if v.IsNumber() {
write(b, op, "%v", v.NumberValue())
} else if v.IsString() {
write(b, op, "%q", v.StringValue())
} else if v.IsComputed() || v.IsOutput() {
// We render computed and output values differently depending on whether or not we are
// planning or deploying: in the former case, we display `computed<type>` or `output<type>`;
// in the former we display `undefined`. This is because we currently cannot distinguish
// between user-supplied undefined values and input properties that are undefined because
// they were sourced from undefined values in other resources' output properties. Once we
// have richer information about the dataflow between resources, we should be able to do a
// better job here (pulumi/pulumi#234).
if planning {
writeVerbatim(b, op, v.TypeString())
} else {
write(b, op, "undefined")
}
} else {
contract.Failf("Unexpected property value kind")
}
}
func printDelete(
b *bytes.Buffer, v resource.PropertyValue, title func(deploy.StepOp, bool),
planning bool, indent int, debug bool) {
op := deploy.OpDelete
title(op, true)
printPropertyValue(b, v, planning, indent, op, true, debug)
}
func printAdd(
b *bytes.Buffer, v resource.PropertyValue, title func(deploy.StepOp, bool),
planning bool, indent int, debug bool) {
op := deploy.OpCreate
title(op, true)
printPropertyValue(b, v, planning, indent, op, true, debug)
}
func printArchiveDiff(
b *bytes.Buffer, titleFunc func(deploy.StepOp, bool),
oldArchive *resource.Archive, newArchive *resource.Archive,
planning bool, indent int, summary bool, debug bool) {
// TODO: this could be called recursively from itself. In the recursive case, we might have an
// archive that actually hasn't changed. Check for that, and terminate the diff printing.
op := deploy.OpUpdate
hashChange := getTextChangeString(shortHash(oldArchive.Hash), shortHash(newArchive.Hash))
if oldPath, has := oldArchive.GetPath(); has {
if newPath, has := newArchive.GetPath(); has {
titleFunc(op, true)
write(b, op, "archive(file:%s) { %s }\n", hashChange, getTextChangeString(oldPath, newPath))
return
}
} else if oldURI, has := oldArchive.GetURI(); has {
if newURI, has := newArchive.GetURI(); has {
titleFunc(op, true)
write(b, op, "archive(uri:%s) { %s }\n", hashChange, getTextChangeString(oldURI, newURI))
return
}
} else {
contract.Assert(oldArchive.IsAssets())
oldAssets, _ := oldArchive.GetAssets()
if newAssets, has := newArchive.GetAssets(); has {
titleFunc(op, true)
write(b, op, "archive(assets:%s) {\n", hashChange)
printAssetsDiff(b, oldAssets, newAssets, planning, indent+1, summary, debug)
writeWithIndentNoPrefix(b, indent, deploy.OpUpdate, "}\n")
return
}
}
// Type of archive changed, print this out as an remove and an add.
printDelete(
b, assetOrArchiveToPropertyValue(oldArchive),
titleFunc, planning, indent, debug)
printAdd(
b, assetOrArchiveToPropertyValue(newArchive),
titleFunc, planning, indent, debug)
}
func printAssetsDiff(
b *bytes.Buffer,
oldAssets map[string]interface{}, newAssets map[string]interface{},
planning bool, indent int, summary bool, debug bool) {
// Diffing assets proceeds by getting the sorted list of asset names from both the old and
// new assets, and then stepwise processing each. For any asset in old that isn't in new,
// we print this out as a delete. For any asset in new that isn't in old, we print this out
// as an add. For any asset in both we print out of it is unchanged or not. If so, we
// recurse on that data to print out how it changed.
var oldNames []string
var newNames []string
for name := range oldAssets {
oldNames = append(oldNames, name)
}
for name := range newAssets {
newNames = append(newNames, name)
}
sort.Strings(oldNames)
sort.Strings(newNames)
i := 0
j := 0
var keys []resource.PropertyKey
for _, name := range oldNames {
keys = append(keys, "\""+resource.PropertyKey(name)+"\"")
}
for _, name := range newNames {
keys = append(keys, "\""+resource.PropertyKey(name)+"\"")
}
maxkey := maxKey(keys)
for i < len(oldNames) || j < len(newNames) {
deleteOld := false
addNew := false
if i < len(oldNames) && j < len(newNames) {
oldName := oldNames[i]
newName := newNames[j]
if oldName == newName {
titleFunc := func(top deploy.StepOp, tprefix bool) {
printPropertyTitle(b, "\""+oldName+"\"", maxkey, indent, top, tprefix)
}
oldAsset := oldAssets[oldName]
newAsset := newAssets[newName]
switch t := oldAsset.(type) {
case *resource.Archive:
printArchiveDiff(
b, titleFunc, t, newAsset.(*resource.Archive),
planning, indent, summary, debug)
case *resource.Asset:
printAssetDiff(
b, titleFunc, t, newAsset.(*resource.Asset),
planning, indent, summary, debug)
}
i++
j++
continue
}
if oldName < newName {
deleteOld = true
} else {
addNew = true
}
} else if i < len(oldNames) {
deleteOld = true
} else {
addNew = true
}
newIndent := indent + 1
if deleteOld {
oldName := oldNames[i]
titleFunc := func(top deploy.StepOp, tprefix bool) {
printPropertyTitle(b, "\""+oldName+"\"", maxkey, indent, top, tprefix)
}
printDelete(
b, assetOrArchiveToPropertyValue(oldAssets[oldName]),
titleFunc, planning, newIndent, debug)
i++
continue
} else {
contract.Assert(addNew)
newName := newNames[j]
titleFunc := func(top deploy.StepOp, tprefix bool) {
printPropertyTitle(b, "\""+newName+"\"", maxkey, indent, top, tprefix)
}
printAdd(
b, assetOrArchiveToPropertyValue(newAssets[newName]),
titleFunc, planning, newIndent, debug)
j++
}
}
}
func makeAssetHeader(asset *resource.Asset) string {
var assetType string
var contents string
if path, has := asset.GetPath(); has {
assetType = "file"
contents = path
} else if uri, has := asset.GetURI(); has {
assetType = "uri"
contents = uri
} else {
assetType = "text"
contents = "..."
}
return fmt.Sprintf("asset(%s:%s) { %s }\n", assetType, shortHash(asset.Hash), contents)
}
func printAssetDiff(
b *bytes.Buffer, titleFunc func(deploy.StepOp, bool),
oldAsset *resource.Asset, newAsset *resource.Asset,
planning bool, indent int, summary bool, debug bool) {
op := deploy.OpUpdate
// If the assets aren't changed, just print out: = assetName: type(hash)
if oldAsset.Hash == newAsset.Hash {
if !summary {
op = deploy.OpSame
titleFunc(op, false)
write(b, op, makeAssetHeader(oldAsset))
}
return
}
// if the asset changed, print out: ~ assetName: type(hash->hash) details...
hashChange := getTextChangeString(shortHash(oldAsset.Hash), shortHash(newAsset.Hash))
if oldAsset.IsText() {
if newAsset.IsText() {
titleFunc(deploy.OpUpdate, true)
write(b, op, "asset(text:%s) {\n", hashChange)
massagedOldText := resource.MassageIfUserProgramCodeAsset(oldAsset, debug).Text
massagedNewText := resource.MassageIfUserProgramCodeAsset(newAsset, debug).Text
differ := diffmatchpatch.New()
differ.DiffTimeout = 0
hashed1, hashed2, lineArray := differ.DiffLinesToChars(massagedOldText, massagedNewText)
diffs1 := differ.DiffMain(hashed1, hashed2, false)
diffs2 := differ.DiffCharsToLines(diffs1, lineArray)
writeString(b, diffToPrettyString(diffs2, indent+1))
writeWithIndentNoPrefix(b, indent, op, "}\n")
return
}
} else if oldPath, has := oldAsset.GetPath(); has {
if newPath, has := newAsset.GetPath(); has {
titleFunc(deploy.OpUpdate, true)
write(b, op, "asset(file:%s) { %s }\n", hashChange, getTextChangeString(oldPath, newPath))
return
}
} else {
contract.Assert(oldAsset.IsURI())
oldURI, _ := oldAsset.GetURI()
if newURI, has := newAsset.GetURI(); has {
titleFunc(deploy.OpUpdate, true)
write(b, op, "asset(uri:%s) { %s }\n", hashChange, getTextChangeString(oldURI, newURI))
return
}
}
// Type of asset changed, print this out as an remove and an add.
printDelete(
b, assetOrArchiveToPropertyValue(oldAsset),
titleFunc, planning, indent, debug)
printAdd(
b, assetOrArchiveToPropertyValue(newAsset),
titleFunc, planning, indent, debug)
}
func getTextChangeString(old string, new string) string {
if old == new {
return old
}
return fmt.Sprintf("%s->%s", old, new)
}
// diffToPrettyString takes the full diff produed by diffmatchpatch and condenses it into something
// useful we can print to the console. Specifically, while it includes any adds/removes in
// green/red, it will also show portions of the unchanged text to help give surrounding context to
// those add/removes. Because the unchanged portions may be very large, it only included around 3
// lines before/after the change.
func diffToPrettyString(diffs []diffmatchpatch.Diff, indent int) string {
var buff bytes.Buffer
writeDiff := func(op deploy.StepOp, text string) {
var prefix bool
if op == deploy.OpCreate || op == deploy.OpDelete {
prefix = true
}
writeWithIndent(&buff, indent, op, prefix, "%s", text)
}
for index, diff := range diffs {
text := diff.Text
lines := strings.Split(text, "\n")
printLines := func(op deploy.StepOp, startInclusive int, endExclusive int) {
for i := startInclusive; i < endExclusive; i++ {
if strings.TrimSpace(lines[i]) != "" {
writeDiff(op, lines[i])
buff.WriteString("\n")
}
}
}
switch diff.Type {
case diffmatchpatch.DiffInsert:
printLines(deploy.OpCreate, 0, len(lines))
case diffmatchpatch.DiffDelete:
printLines(deploy.OpDelete, 0, len(lines))
case diffmatchpatch.DiffEqual:
var trimmedLines []string
for _, line := range lines {
if strings.TrimSpace(line) != "" {
trimmedLines = append(trimmedLines, line)
}
}
lines = trimmedLines
const contextLines = 2
// Show the unchanged text in white.
if index == 0 {
// First chunk of the file.
if len(lines) > contextLines+1 {
writeDiff(deploy.OpSame, "...\n")
printLines(deploy.OpSame, len(lines)-contextLines, len(lines))
continue
}
} else if index == len(diffs)-1 {
if len(lines) > contextLines+1 {
printLines(deploy.OpSame, 0, contextLines)
writeDiff(deploy.OpSame, "...\n")
continue
}
} else {
if len(lines) > (2*contextLines + 1) {
printLines(deploy.OpSame, 0, contextLines)
writeDiff(deploy.OpSame, "...\n")
printLines(deploy.OpSame, len(lines)-contextLines, len(lines))
continue
}
}
printLines(deploy.OpSame, 0, len(lines))
}
}
return buff.String()
}