5f9ed13069
This change simplifies the generated Check interface for providers.
Instead of
Check(ctx context.Context, obj *T) ([]error, error)
where T is the resource type, we have
Check(ctx context.Context, obj *T, property string) error
This is done so that we can drive the calls to Check one property
at a time, allowing us to skip any that are computed. (Otherwise,
we may fail the verification erroneously.)
This has the added advantage that the Check implementations are
simpler and can simply return a single error. Furthermore, the
generated RPC code handles wrapping the result, so we can just do
return errors.New("bad");
rather than the previous reflection-laden junk
return resource.NewFieldError(
reflect.TypeOf(obj), awsservice.AWSResource_Property,
errors.New("bad"))
32 lines
1.5 KiB
Go
32 lines
1.5 KiB
Go
// Licensed to Pulumi Corporation ("Pulumi") under one or more
|
|
// contributor license agreements. See the NOTICE file distributed with
|
|
// this work for additional information regarding copyright ownership.
|
|
// Pulumi licenses this file to You under the Apache License, Version 2.0
|
|
// (the "License"); you may not use this file except in compliance with
|
|
// the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package resource
|
|
|
|
import (
|
|
"github.com/pulumi/lumi/pkg/util/mapper"
|
|
)
|
|
|
|
// NewErrors creates a new error list pertaining to a resource. Note that it just turns around and defers to
|
|
// the same mapping infrastructure used for serialization and deserialization, but it presents a nicer interface.
|
|
func NewErrors(errs []error) error {
|
|
return mapper.NewMappingError(errs)
|
|
}
|
|
|
|
// NewPropertyError creates a new error pertaining to a resource's property. Note that it just turns around and defers
|
|
// to the same mapping infrastructure used for serialization and deserialization, but it presents a nicer interface.
|
|
func NewPropertyError(typ string, property string, err error) error {
|
|
return mapper.NewFieldError(typ, property, err)
|
|
}
|