pulumi/pkg/codegen/utilities.go
Pat Gavlin 1d6cce98fe
[codegen/python] Fix nested quotes. (#4539)
Unlike most languages with interpolated strings, Python's formatted
string literals do not allow the nesting of quotes. For example,
this expression is not legal Python:

    f"Foo {"bar"} baz"

If an interpolation requires quotes, those quotes nust differ from the
quotes used by the enclosing literal. We can fix the previous example
by rewriting it with single quotes:

    f"Foo {'bar'} baz"

However, this presents a problem if there are more than two levels of
nesting, as Python only has two kinds of quotes (four if the outermost
string uses """ or '''): in this case, the expression becomes
unspellable, and must be assigned to a local that is then used in place
of the original expression. So this:

    f"Foo {bar[f'index {baz["qux"]}']} zed"

becomes this:

    index = "qux"
    f"Foo {bar[f'index {baz[index]}']}"

To put it bluntly, Python code generation reqiures register allocation,
but for quotes. These changes implement exactly that.

These changes also include a fix for traversals that access values that
are dictionaries rather than objects, and must use indexers rather than
attributes.
2020-04-30 16:34:25 -07:00

82 lines
1.8 KiB
Go

// Copyright 2016-2020, Pulumi Corporation.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package codegen
import (
"reflect"
"sort"
"github.com/pulumi/pulumi/sdk/v2/go/common/util/contract"
)
type StringSet map[string]struct{}
func NewStringSet(values ...string) StringSet {
s := StringSet{}
for _, v := range values {
s.Add(v)
}
return s
}
func (ss StringSet) Add(s string) {
ss[s] = struct{}{}
}
func (ss StringSet) Delete(s string) {
delete(ss, s)
}
func (ss StringSet) Has(s string) bool {
_, ok := ss[s]
return ok
}
func (ss StringSet) SortedValues() []string {
values := make([]string, 0, len(ss))
for v := range ss {
values = append(values, v)
}
sort.Strings(values)
return values
}
type Set map[interface{}]struct{}
func (s Set) Add(v interface{}) {
s[v] = struct{}{}
}
func (s Set) Has(v interface{}) bool {
_, ok := s[v]
return ok
}
// SortedKeys returns a sorted list of keys for the given map. The map's key type must be of kind string.
func SortedKeys(m interface{}) []string {
mv := reflect.ValueOf(m)
contract.Require(mv.Type().Kind() == reflect.Map, "m")
contract.Require(mv.Type().Key().Kind() == reflect.String, "m")
keys := make([]string, mv.Len())
for i, k := range mv.MapKeys() {
keys[i] = k.String()
}
sort.Strings(keys)
return keys
}