* Add a list of in-flight operations to the deployment This commit augments 'DeploymentV2' with a list of operations that are currently in flight. This information is used by the engine to keep track of whether or not a particular deployment is in a valid state. The SnapshotManager is responsible for inserting and removing operations from the in-flight operation list. When the engine registers an intent to perform an operation, SnapshotManager inserts an Operation into this list and saves it to the snapshot. When an operation completes, the SnapshotManager removes it from the snapshot. From this, the engine can infer that if it ever sees a deployment with pending operations, the Pulumi CLI must have crashed or otherwise abnormally terminated before seeing whether or not an operation completed successfully. To remedy this state, this commit also adds code to 'pulumi stack import' that clears all pending operations from a deployment, as well as code to plan generation that will reject any deployments that have pending operations present. At the CLI level, if we see that we are in a state where pending operations were in-flight when the engine died, we'll issue a human-friendly error message that indicates which resources are in a bad state and how to recover their stack. * CR: Multi-line string literals, renaming in-flight -> pending * CR: Add enum to apitype for operation type, also name status -> type for clarity * Fix the yaml type * Fix missed renames * Add implementation for lifecycle_test.go * Rebase against master
151 lines
5.4 KiB
Go
151 lines
5.4 KiB
Go
// Copyright 2016-2018, Pulumi Corporation.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/hashicorp/go-multierror"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/pulumi/pulumi/pkg/apitype"
|
|
"github.com/pulumi/pulumi/pkg/backend"
|
|
"github.com/pulumi/pulumi/pkg/diag"
|
|
"github.com/pulumi/pulumi/pkg/resource/stack"
|
|
"github.com/pulumi/pulumi/pkg/util/cmdutil"
|
|
)
|
|
|
|
func newStackImportCmd() *cobra.Command {
|
|
var force bool
|
|
var file string
|
|
var stackName string
|
|
cmd := &cobra.Command{
|
|
Use: "import",
|
|
Args: cmdutil.MaximumNArgs(0),
|
|
Short: "Import a deployment from standard in into an existing stack",
|
|
Long: "Import a deployment from standard in into an existing stack.\n" +
|
|
"\n" +
|
|
"A deployment that was exported from a stack using `pulumi stack export` and\n" +
|
|
"hand-edited to correct inconsistencies due to failed updates, manual changes\n" +
|
|
"to cloud resources, etc. can be reimported to the stack using this command.\n" +
|
|
"The updated deployment will be read from standard in.",
|
|
Run: cmdutil.RunFunc(func(cmd *cobra.Command, args []string) error {
|
|
opts := backend.DisplayOptions{
|
|
Color: cmdutil.GetGlobalColorization(),
|
|
}
|
|
|
|
// Fetch the current stack and import a deployment.
|
|
s, err := requireStack(stackName, false, opts, true /*setCurrent*/)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Read from stdin or a specified file
|
|
reader := os.Stdin
|
|
if file != "" {
|
|
reader, err = os.Open(file)
|
|
if err != nil {
|
|
return errors.Wrap(err, "could not open file")
|
|
}
|
|
}
|
|
|
|
// Read the checkpoint from stdin. We decode this into a json.RawMessage so as not to lose any fields
|
|
// sent by the server that the client CLI does not recognize (enabling round-tripping).
|
|
var deployment apitype.UntypedDeployment
|
|
if err = json.NewDecoder(reader).Decode(&deployment); err != nil {
|
|
return err
|
|
}
|
|
|
|
// We do, however, now want to unmarshal the json.RawMessage into a real, typed deployment. We do this so
|
|
// we can check that the deployment doesn't contain resources from a stack other than the selected one. This
|
|
// catches errors wherein someone imports the wrong stack's deployment (which can seriously hork things).
|
|
snapshot, err := stack.DeserializeUntypedDeployment(&deployment)
|
|
if err != nil {
|
|
switch err {
|
|
case stack.ErrDeploymentSchemaVersionTooOld:
|
|
return fmt.Errorf("the stack '%s' is too old to be used by this version of the Pulumi CLI",
|
|
s.Name().StackName())
|
|
case stack.ErrDeploymentSchemaVersionTooNew:
|
|
return fmt.Errorf("the stack '%s' is newer than what this version of the Pulumi CLI understands. "+
|
|
"Please update your version of the Pulumi CLI", s.Name().StackName())
|
|
}
|
|
|
|
return errors.Wrap(err, "could not deserialize deployment")
|
|
}
|
|
|
|
var result error
|
|
for _, res := range snapshot.Resources {
|
|
if res.URN.Stack() != s.Name().StackName() {
|
|
msg := fmt.Sprintf("resource '%s' is from a different stack (%s != %s)",
|
|
res.URN, res.URN.Stack(), s.Name().StackName())
|
|
if force {
|
|
// If --force was passed, just issue a warning and proceed anyway.
|
|
// Note: we could associate this diagnostic with the resource URN
|
|
// we have. However, this sort of message seems to be better as
|
|
// something associated with the stack as a whole.
|
|
cmdutil.Diag().Warningf(diag.Message("" /*urn*/, msg))
|
|
} else {
|
|
// Otherwise, gather up an error so that we can quit before doing damage.
|
|
result = multierror.Append(result, errors.New(msg))
|
|
}
|
|
}
|
|
}
|
|
if result != nil {
|
|
return multierror.Append(result,
|
|
errors.New("importing this file could be dangerous; rerun with --force to proceed anyway"))
|
|
}
|
|
|
|
// Explicitly clear-out any pending operations.
|
|
if snapshot.PendingOperations != nil {
|
|
for _, op := range snapshot.PendingOperations {
|
|
msg := fmt.Sprintf(
|
|
"removing pending operation '%s' on '%s' from snapshot", op.Type, op.Resource.URN)
|
|
cmdutil.Diag().Warningf(diag.Message(op.Resource.URN, msg))
|
|
}
|
|
|
|
snapshot.PendingOperations = nil
|
|
}
|
|
bytes, err := json.Marshal(stack.SerializeDeployment(snapshot))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
dep := apitype.UntypedDeployment{
|
|
Version: apitype.DeploymentSchemaVersionCurrent,
|
|
Deployment: bytes,
|
|
}
|
|
|
|
// Now perform the deployment.
|
|
if err = s.ImportDeployment(commandContext(), &dep); err != nil {
|
|
return errors.Wrap(err, "could not import deployment")
|
|
}
|
|
fmt.Printf("Import successful.\n")
|
|
return nil
|
|
}),
|
|
}
|
|
|
|
cmd.PersistentFlags().StringVarP(
|
|
&stackName, "stack", "s", "", "The name of the stack to operate on. Defaults to the current stack")
|
|
cmd.PersistentFlags().BoolVarP(
|
|
&force, "force", "f", false,
|
|
"Force the import to occur, even if apparent errors are discovered beforehand (not recommended)")
|
|
cmd.PersistentFlags().StringVarP(
|
|
&file, "file", "", "", "A filename to read stack input from")
|
|
|
|
return cmd
|
|
}
|