When calculating deletes, we will only issue a single delete step for a particular URN. This is incorrect in the presence of pending deletes that share URNs with a live resource if the pending deletes follow the live resource in the checkpoint: instead of issuing a delete for every resource with a particular URN, we will only issue deletes for the pending deletes. Before first-class providers, this was mostly benigin: any remaining resources could be deleted by re-running the destroy. With the first-class provider changes, however, the provider for the undeleted resources will be deleted, leaving the checkpoint in an invalid state. These changes fix this issue by allowing the step generator to issue multiple deletes for a single URN and add a test for this scenario.
47 lines
1.2 KiB
Go
47 lines
1.2 KiB
Go
// Copyright 2016-2018, Pulumi Corporation.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package ints
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/pulumi/pulumi/pkg/testing/integration"
|
|
)
|
|
|
|
// Test that the engine does not tolerate duplicate URNs in the same plan.
|
|
func TestDuplicateURNs(t *testing.T) {
|
|
integration.ProgramTest(t, &integration.ProgramTestOptions{
|
|
Dir: "step1",
|
|
Dependencies: []string{"@pulumi/pulumi"},
|
|
Quick: true,
|
|
ExpectFailure: true,
|
|
EditDirs: []integration.EditDir{
|
|
{
|
|
Dir: "step2",
|
|
Additive: true,
|
|
},
|
|
{
|
|
Dir: "step3",
|
|
Additive: true,
|
|
ExpectFailure: true,
|
|
},
|
|
{
|
|
Dir: "step4",
|
|
Additive: true,
|
|
ExpectFailure: true,
|
|
},
|
|
},
|
|
})
|
|
}
|