5d17bcf1bc
To allow seamless copy-paste, on Ctrl+v, a SET_CLIPBOARD request is performed before injecting Ctrl+v. But when HID keyboard is enabled, the Ctrl+v injection is not sent on the same channel as the clipboard request, so they are not serialized, and may occur in any order. If Ctrl+v happens to be injected before the new clipboard content is set, then the old content is pasted instead, which is incorrect. To minimize the probability of occurrence of the wrong order, a delay of 2 milliseconds was added before injecting Ctrl+v. Then 5ms. But even with 5ms, the wrong behavior sometimes happens. To handle it properly, add an acknowledgement mechanism, so that Ctrl+v is injected over AOA only after the SET_CLIPBOARD request has been performed and acknowledged by the server. Refse4163321f0Refs45b0f8123aPR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
49 lines
1.3 KiB
C
49 lines
1.3 KiB
C
#ifndef SC_KEY_PROCESSOR_H
|
|
#define SC_KEY_PROCESSOR_H
|
|
|
|
#include "common.h"
|
|
|
|
#include <assert.h>
|
|
#include <stdbool.h>
|
|
|
|
#include <SDL2/SDL_events.h>
|
|
|
|
/**
|
|
* Key processor trait.
|
|
*
|
|
* Component able to process and inject keys should implement this trait.
|
|
*/
|
|
struct sc_key_processor {
|
|
/**
|
|
* Set by the implementation to indicate that it must explicitly wait for
|
|
* the clipboard to be set on the device before injecting Ctrl+v to avoid
|
|
* race conditions. If it is set, the input_manager will pass a valid
|
|
* ack_to_wait to process_key() in case of clipboard synchronization
|
|
* resulting of the key event.
|
|
*/
|
|
bool async_paste;
|
|
|
|
const struct sc_key_processor_ops *ops;
|
|
};
|
|
|
|
struct sc_key_processor_ops {
|
|
|
|
/**
|
|
* Process the keyboard event
|
|
*
|
|
* The `sequence` number (if different from `SC_SEQUENCE_INVALID`) indicates
|
|
* the acknowledgement number to wait for before injecting this event.
|
|
* This allows to ensure that the device clipboard is set before injecting
|
|
* Ctrl+v on the device.
|
|
*/
|
|
void
|
|
(*process_key)(struct sc_key_processor *kp, const SDL_KeyboardEvent *event,
|
|
uint64_t ack_to_wait);
|
|
|
|
void
|
|
(*process_text)(struct sc_key_processor *kp,
|
|
const SDL_TextInputEvent *event);
|
|
};
|
|
|
|
#endif
|