maxmustermann/synapse
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Disable validation that a UI authentication session has not been modified during a request cycle.

Browse source 
Partial backout of 1c1242acba (#7068)
This commit is contained in:
Patrick Cloke 2020-05-07 08:34:12 -04:00
parent d9b8d27494
commit 4d3ebc3620
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
synapse/handlers/auth.py
View file

@ -329,18 +329,6 @@ class AuthHandler(BaseHandler):
# isn't arbitrary.
clientdict = session.clientdict
# Ensure that the queried operation does not vary between stages of
# the UI authentication session. This is done by generating a stable
# comparator based on the URI, method, and body (minus the auth dict)
# and storing it during the initial query. Subsequent queries ensure
# that this comparator has not changed.
comparator = (uri, method, clientdict)
if (session.uri, session.method, session.clientdict) != comparator:
raise SynapseError(
403,
"Requested operation has changed during the UI authentication session.",
)
if not authdict:
raise InteractiveAuthIncompleteError(
self._auth_dict_for_flows(flows, session.session_id)