Merge pull request #5658 from matrix-org/babolivier/is-json

Send 3PID bind requests as JSON data
This commit is contained in:
Brendan Abolivier 2019-07-10 17:01:26 +01:00 committed by GitHub
commit 8ab3444fdf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions

1
changelog.d/5658.bugfix Normal file
View file

@ -0,0 +1 @@
Fix 3PID bind requests being sent to identity servers as `application/x-form-www-urlencoded` data, which is deprecated.

View file

@ -118,7 +118,7 @@ class IdentityHandler(BaseHandler):
raise SynapseError(400, "No client_secret in creds") raise SynapseError(400, "No client_secret in creds")
try: try:
data = yield self.http_client.post_urlencoded_get_json( data = yield self.http_client.post_json_get_json(
"https://%s%s" % (id_server, "/_matrix/identity/api/v1/3pid/bind"), "https://%s%s" % (id_server, "/_matrix/identity/api/v1/3pid/bind"),
{"sid": creds["sid"], "client_secret": client_secret, "mxid": mxid}, {"sid": creds["sid"], "client_secret": client_secret, "mxid": mxid},
) )