maxmustermann/synapse
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Check on room creation if the user is allowed to publish the room to the room directory. (#7260)

Browse source
This commit is contained in:
PeerD 2020-04-13 13:42:32 +02:00 committed by GitHub
parent 118b58f0c9
commit f41b742161
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/7260.bugfix Normal file
View file

@ -0,0 +1 @@
Fix room publish permissions not being checked on room creation.

7
synapse/handlers/room.py
View file

@ -645,6 +645,13 @@ class RoomCreationHandler(BaseHandler):
check_membership=False,
)
if is_public:
if not self.config.is_publishing_room_allowed(user_id, room_id, room_alias):
# Lets just return a generic message, as there may be all sorts of
# reasons why we said no. TODO: Allow configurable error messages
# per alias creation rule?
raise SynapseError(403, "Not allowed to publish room")
preset_config = config.get(
"preset",
RoomCreationPreset.PRIVATE_CHAT