1531b214fc
The idea here is that if an instance persists an event via the replication HTTP API it can return before we receive that event over replication, which can lead to races where code assumes that persisting an event immediately updates various caches (e.g. current state of the room). Most of Synapse doesn't hit such races, so we don't do the waiting automagically, instead we do so where necessary to avoid unnecessary delays. We may decide to change our minds here if it turns out there are a lot of subtle races going on. People probably want to look at this commit by commit.
96 lines
3.2 KiB
Python
96 lines
3.2 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2018 New Vector Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import logging
|
|
from typing import List, Optional, Tuple
|
|
|
|
from synapse.api.errors import SynapseError
|
|
from synapse.handlers.room_member import RoomMemberHandler
|
|
from synapse.replication.http.membership import (
|
|
ReplicationRemoteJoinRestServlet as ReplRemoteJoin,
|
|
ReplicationRemoteRejectInviteRestServlet as ReplRejectInvite,
|
|
ReplicationUserJoinedLeftRoomRestServlet as ReplJoinedLeft,
|
|
)
|
|
from synapse.types import Requester, UserID
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class RoomMemberWorkerHandler(RoomMemberHandler):
|
|
def __init__(self, hs):
|
|
super(RoomMemberWorkerHandler, self).__init__(hs)
|
|
|
|
self._remote_join_client = ReplRemoteJoin.make_client(hs)
|
|
self._remote_reject_client = ReplRejectInvite.make_client(hs)
|
|
self._notify_change_client = ReplJoinedLeft.make_client(hs)
|
|
|
|
async def _remote_join(
|
|
self,
|
|
requester: Requester,
|
|
remote_room_hosts: List[str],
|
|
room_id: str,
|
|
user: UserID,
|
|
content: dict,
|
|
) -> Tuple[str, int]:
|
|
"""Implements RoomMemberHandler._remote_join
|
|
"""
|
|
if len(remote_room_hosts) == 0:
|
|
raise SynapseError(404, "No known servers")
|
|
|
|
ret = await self._remote_join_client(
|
|
requester=requester,
|
|
remote_room_hosts=remote_room_hosts,
|
|
room_id=room_id,
|
|
user_id=user.to_string(),
|
|
content=content,
|
|
)
|
|
|
|
await self._user_joined_room(user, room_id)
|
|
|
|
return ret["event_id"], ret["stream_id"]
|
|
|
|
async def _remote_reject_invite(
|
|
self,
|
|
requester: Requester,
|
|
remote_room_hosts: List[str],
|
|
room_id: str,
|
|
target: UserID,
|
|
content: dict,
|
|
) -> Tuple[Optional[str], int]:
|
|
"""Implements RoomMemberHandler._remote_reject_invite
|
|
"""
|
|
ret = await self._remote_reject_client(
|
|
requester=requester,
|
|
remote_room_hosts=remote_room_hosts,
|
|
room_id=room_id,
|
|
user_id=target.to_string(),
|
|
content=content,
|
|
)
|
|
return ret["event_id"], ret["stream_id"]
|
|
|
|
async def _user_joined_room(self, target: UserID, room_id: str) -> None:
|
|
"""Implements RoomMemberHandler._user_joined_room
|
|
"""
|
|
await self._notify_change_client(
|
|
user_id=target.to_string(), room_id=room_id, change="joined"
|
|
)
|
|
|
|
async def _user_left_room(self, target: UserID, room_id: str) -> None:
|
|
"""Implements RoomMemberHandler._user_left_room
|
|
"""
|
|
await self._notify_change_client(
|
|
user_id=target.to_string(), room_id=room_id, change="left"
|
|
)
|