2019-05-03 00:29:04 +02:00
|
|
|
/*++
|
|
|
|
Copyright (c) Microsoft Corporation
|
|
|
|
Licensed under the MIT license.
|
|
|
|
|
|
|
|
Module Name:
|
|
|
|
- AttrRow.hpp
|
|
|
|
|
|
|
|
Abstract:
|
|
|
|
- contains data structure for the attributes of one row of screen buffer
|
|
|
|
|
|
|
|
Author(s):
|
|
|
|
- Michael Niksa (miniksa) 10-Apr-2014
|
|
|
|
- Paul Campbell (paulcam) 10-Apr-2014
|
|
|
|
|
|
|
|
Revision History:
|
|
|
|
- From components of output.h/.c
|
|
|
|
by Therese Stowell (ThereseS) 1990-1991
|
|
|
|
- Pulled into its own file from textBuffer.hpp/cpp (AustDi, 2017)
|
|
|
|
--*/
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
2021-05-20 19:27:50 +02:00
|
|
|
#include "til/rle.h"
|
|
|
|
#include "TextAttribute.hpp"
|
2019-05-03 00:29:04 +02:00
|
|
|
|
|
|
|
class ATTR_ROW final
|
|
|
|
{
|
2021-05-20 19:27:50 +02:00
|
|
|
using rle_vector = til::small_rle<TextAttribute, uint16_t, 1>;
|
|
|
|
|
2019-05-03 00:29:04 +02:00
|
|
|
public:
|
2021-05-20 19:27:50 +02:00
|
|
|
using const_iterator = rle_vector::const_iterator;
|
2019-05-03 00:29:04 +02:00
|
|
|
|
2021-05-20 19:27:50 +02:00
|
|
|
ATTR_ROW(uint16_t width, TextAttribute attr);
|
Greatly reduce allocations in the conhost/OpenConsole startup path (#8489)
I was looking at conhost/OpenConsole and noticed it was being pretty
inefficient with allocations due to some usages of std::deque and
std::vector that didn't need to be done quite that way.
So this uses std::vector for the TextBuffer's storage of ROW objects,
which allows one allocation to contiguously reserve space for all the
ROWs - on Desktop this is 9001 ROW objects which means it saves 9000
allocations that the std::deque would have done. Plus it has the
benefit of increasing locality of the ROW objects since deque is going
to chase pointers more often with its data structure.
Then, within each ROW there are CharRow and ATTR_ROW objects that use
std::vector today. This changes them to use Boost's small_vector, which
is a variation of vector that allows for the so-called "small string
optimization." Since we know the typical size of these vectors, we can
pre-reserve the right number of elements directly in the
CharRow/ATTR_ROW instances, avoiding any heap allocations at all for
constructing these objects.
There are a ton of variations on this "small_vector" concept out there
in the world - this one in Boost, LLVM has one called SmallVector,
Electronic Arts' STL has a small_vector, Facebook's folly library has
one...there are a silly number of these out there. But Boost seems like
it's by far the easiest to consume in terms of integration into this
repo, the CI/CD pipeline, licensing, and stuff like that, so I went with
the boost version.
In terms of numbers, I measured the startup path of OpenConsole.exe on
my dev box for Release x64 configuration. My box is an i7-6700k @ 4
Ghz, with 32 GB RAM, not that I think machine config matters much here:
| | Allocation count | Allocated bytes | CPU usage (ms) |
| ------ | ------------------- | ------------------ | -------------- |
| Before | 29,461 | 4,984,640 | 103 |
| After | 2,459 (-91%) | 4,853,931 (-2.6%) | 96 (-7%) |
Along the way, I also fixed a dynamic initializer I happened to spot in
the registry code, and updated some docs.
## Validation Steps Performed
- Ran "runut", "runft" and "runuia" locally and confirmed results are
the same as the main branch
- Profiled the before/after numbers in the Visual Studio profiler, for
the numbers shown in the table
Co-authored-by: Austin Lamb <austinl@microsoft.com>
2020-12-16 19:40:30 +01:00
|
|
|
|
|
|
|
~ATTR_ROW() = default;
|
|
|
|
|
|
|
|
ATTR_ROW(const ATTR_ROW&) = default;
|
|
|
|
ATTR_ROW& operator=(const ATTR_ROW&) = default;
|
|
|
|
ATTR_ROW(ATTR_ROW&&)
|
|
|
|
noexcept = default;
|
|
|
|
ATTR_ROW& operator=(ATTR_ROW&&) noexcept = default;
|
2019-05-03 00:29:04 +02:00
|
|
|
|
2021-05-20 19:27:50 +02:00
|
|
|
TextAttribute GetAttrByColumn(uint16_t column) const;
|
|
|
|
std::vector<uint16_t> GetHyperlinks() const;
|
2019-05-03 00:29:04 +02:00
|
|
|
|
2021-05-20 19:27:50 +02:00
|
|
|
bool SetAttrToEnd(uint16_t beginIndex, TextAttribute attr);
|
|
|
|
void ReplaceAttrs(const TextAttribute& toBeReplacedAttr, const TextAttribute& replaceWith);
|
|
|
|
void Resize(uint16_t newWidth);
|
|
|
|
void Replace(uint16_t beginIndex, uint16_t endIndex, const TextAttribute& newAttr);
|
2019-05-03 00:29:04 +02:00
|
|
|
|
|
|
|
const_iterator begin() const noexcept;
|
|
|
|
const_iterator end() const noexcept;
|
|
|
|
|
|
|
|
const_iterator cbegin() const noexcept;
|
|
|
|
const_iterator cend() const noexcept;
|
|
|
|
|
|
|
|
friend bool operator==(const ATTR_ROW& a, const ATTR_ROW& b) noexcept;
|
2021-01-20 22:16:56 +01:00
|
|
|
friend class ROW;
|
2019-05-03 00:29:04 +02:00
|
|
|
|
|
|
|
private:
|
2021-01-20 22:16:56 +01:00
|
|
|
void Reset(const TextAttribute attr);
|
|
|
|
|
2021-05-20 19:27:50 +02:00
|
|
|
rle_vector _data;
|
2019-05-03 00:29:04 +02:00
|
|
|
|
|
|
|
#ifdef UNIT_TESTING
|
2021-01-20 22:16:56 +01:00
|
|
|
friend class CommonState;
|
2019-05-03 00:29:04 +02:00
|
|
|
#endif
|
|
|
|
};
|