diff --git a/src/cascadia/TerminalSettingsEditor/Appearances.xaml b/src/cascadia/TerminalSettingsEditor/Appearances.xaml index 5d5c99645..244140b22 100644 --- a/src/cascadia/TerminalSettingsEditor/Appearances.xaml +++ b/src/cascadia/TerminalSettingsEditor/Appearances.xaml @@ -172,7 +172,7 @@ ClearSettingValue="{x:Bind Appearance.ClearCursorShape}" HasSettingValue="{x:Bind Appearance.HasCursorShape, Mode=OneWay}" SettingOverrideSource="{x:Bind Appearance.CursorShapeOverrideSource, Mode=OneWay}" - Style="{StaticResource AlternativeSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> @@ -234,6 +236,7 @@ @@ -451,7 +455,7 @@ ClearSettingValue="{x:Bind Appearance.ClearIntenseTextStyle}" HasSettingValue="{x:Bind Appearance.HasIntenseTextStyle, Mode=OneWay}" SettingOverrideSource="{x:Bind Appearance.IntenseTextStyleOverrideSource, Mode=OneWay}" - Style="{StaticResource AlternativeSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> - + @@ -64,7 +66,7 @@ + Style="{StaticResource ExpanderSettingContainerStyle}"> - + + Style="{StaticResource ExpanderSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> @@ -77,6 +79,8 @@ ClearSettingValue="{x:Bind State.Profile.ClearCommandline}" HasSettingValue="{x:Bind State.Profile.HasCommandline, Mode=OneWay}" SettingOverrideSource="{x:Bind State.Profile.CommandlineOverrideSource, Mode=OneWay}" + Style="{StaticResource ExpanderSettingContainerStyle}" + CurrentValue="{x:Bind State.Profile.Commandline, Mode=OneWay}" Visibility="{x:Bind local:Converters.InvertedBooleanToVisibility(State.Profile.IsBaseLayer), Mode=OneWay}"> @@ -118,6 +124,8 @@ + Style="{StaticResource ExpanderSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> + Style="{StaticResource ExpanderSettingContainerStyle}"> diff --git a/src/cascadia/TerminalSettingsEditor/SettingContainer.cpp b/src/cascadia/TerminalSettingsEditor/SettingContainer.cpp index 0dac71246..6b1189fe0 100644 --- a/src/cascadia/TerminalSettingsEditor/SettingContainer.cpp +++ b/src/cascadia/TerminalSettingsEditor/SettingContainer.cpp @@ -12,6 +12,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation { DependencyProperty SettingContainer::_HeaderProperty{ nullptr }; DependencyProperty SettingContainer::_HelpTextProperty{ nullptr }; + DependencyProperty SettingContainer::_CurrentValueProperty{ nullptr }; DependencyProperty SettingContainer::_HasSettingValueProperty{ nullptr }; DependencyProperty SettingContainer::_SettingOverrideSourceProperty{ nullptr }; @@ -43,6 +44,15 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation xaml_typename(), PropertyMetadata{ box_value(L"") }); } + if (!_CurrentValueProperty) + { + _CurrentValueProperty = + DependencyProperty::Register( + L"CurrentValue", + xaml_typename(), + xaml_typename(), + PropertyMetadata{ box_value(L"") }); + } if (!_HasSettingValueProperty) { _HasSettingValueProperty = @@ -72,23 +82,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation void SettingContainer::OnApplyTemplate() { - if (const auto& child{ GetTemplateChild(L"ExpanderButton") }) - { - if (const auto& toggleButton{ child.try_as() }) - { - toggleButton.Click([=](auto&&, auto&&) { - if (const auto& expanderChild{ GetTemplateChild(L"MainContentContainer") }) - { - if (const auto& expander{ expanderChild.try_as() }) - { - const auto newVisibility = expander.Visibility() == Visibility::Visible ? Visibility::Collapsed : Visibility::Visible; - expander.Visibility(newVisibility); - } - } - }); - } - } - if (const auto& child{ GetTemplateChild(L"ResetButton") }) { if (const auto& button{ child.try_as() }) diff --git a/src/cascadia/TerminalSettingsEditor/SettingContainer.h b/src/cascadia/TerminalSettingsEditor/SettingContainer.h index de9570e7f..7accd8735 100644 --- a/src/cascadia/TerminalSettingsEditor/SettingContainer.h +++ b/src/cascadia/TerminalSettingsEditor/SettingContainer.h @@ -31,6 +31,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation DEPENDENCY_PROPERTY(Windows::Foundation::IInspectable, Header); DEPENDENCY_PROPERTY(hstring, HelpText); + DEPENDENCY_PROPERTY(hstring, CurrentValue); DEPENDENCY_PROPERTY(bool, HasSettingValue); DEPENDENCY_PROPERTY(IInspectable, SettingOverrideSource); TYPED_EVENT(ClearSettingValue, Editor::SettingContainer, Windows::Foundation::IInspectable); diff --git a/src/cascadia/TerminalSettingsEditor/SettingContainer.idl b/src/cascadia/TerminalSettingsEditor/SettingContainer.idl index 3c75cd2dc..39638ca4f 100644 --- a/src/cascadia/TerminalSettingsEditor/SettingContainer.idl +++ b/src/cascadia/TerminalSettingsEditor/SettingContainer.idl @@ -13,6 +13,9 @@ namespace Microsoft.Terminal.Settings.Editor String HelpText; static Windows.UI.Xaml.DependencyProperty HelpTextProperty { get; }; + String CurrentValue; + static Windows.UI.Xaml.DependencyProperty CurrentValueProperty { get; }; + Boolean HasSettingValue; static Windows.UI.Xaml.DependencyProperty HasSettingValueProperty { get; }; diff --git a/src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml b/src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml index 07ba94b64..3d88cbfe1 100644 --- a/src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml +++ b/src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml @@ -7,6 +7,7 @@ xmlns:d="http://schemas.microsoft.com/expression/blend/2008" xmlns:local="using:Microsoft.Terminal.Settings.Editor" xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" + xmlns:muxc="using:Microsoft.UI.Xaml.Controls" mc:Ignorable="d"> @@ -124,423 +125,6 @@ - - - - + +