maxmustermann/terminal
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Apparently, event names are GLOBAL so reusing the same name is VERY DUMB

Browse source
This commit is contained in:
Mike Griese 2021-08-25 10:44:37 -05:00
parent 6b6ca8fe60
commit 36fb572308
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/cascadia/TerminalApp/TabManagement.cpp
View file

@ -238,7 +238,7 @@ namespace winrt::TerminalApp::implementation
// ready to go. We won't need the event after this function, so the
// unique_event will clean up our handle when we leave this scope. The
// ContentProcess is responsible for cleaning up its own handle.
wil::unique_event ev{ CreateEvent(nullptr, true, false, L"contentProcessStarted") };
wil::unique_event ev{ CreateEvent(nullptr, true, false, nullptr/*L"contentProcessStarted"*/) };
// Make sure to mark this handle as inheritable! Even with
// bInheritHandles=true, this is only inherited when it's explicitly
// allowed to be.

2
src/cascadia/WindowsTerminal/ContentProcessMain.cpp
View file

@ -138,7 +138,7 @@ void TryRunAsContentProcess()
HANDLE eventHandle{ INVALID_HANDLE_VALUE };
if (checkIfContentProcess(contentProcessGuid, eventHandle))
{
g_canExitThread = wil::unique_event{ CreateEvent(nullptr, true, false, L"ContentProcessReady") };
g_canExitThread = wil::unique_event{ CreateEvent(nullptr, true, false, nullptr/*L"ContentProcessReady"*/) };
doContentProcessThing(contentProcessGuid, eventHandle);