From 40b557a4b629dbdec1ce9a7aaea26daefff5ca1f Mon Sep 17 00:00:00 2001 From: Michael Niksa Date: Fri, 24 May 2019 14:26:40 -0700 Subject: [PATCH] Update manifest to correct 1903 version, unref param fix (#1008) * Update manifest to correct 1903 version While messing around with building with VS2019/14.2/etc, I noticed that the version we're using in the compatibility manifest doesn't match guidance for XAML Islands. This puts the version information from the public guidance into the manifest and leaves a link back to the page where I got this idea from. * comment out unused params in IslandWindow::OnResize --- src/cascadia/WindowsTerminal/IslandWindow.cpp | 2 +- src/cascadia/WindowsTerminal/WindowsTerminal.manifest | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/cascadia/WindowsTerminal/IslandWindow.cpp b/src/cascadia/WindowsTerminal/IslandWindow.cpp index 4097576e6..9eda653b7 100644 --- a/src/cascadia/WindowsTerminal/IslandWindow.cpp +++ b/src/cascadia/WindowsTerminal/IslandWindow.cpp @@ -173,7 +173,7 @@ LRESULT IslandWindow::MessageHandler(UINT const message, WPARAM const wparam, LP // Arguments: // - width: the new width of the window _in pixels_ // - height: the new height of the window _in pixels_ -void IslandWindow::OnResize(const UINT width, const UINT height) +void IslandWindow::OnResize(const UINT /*width*/, const UINT /*height*/) { OnSize(); } diff --git a/src/cascadia/WindowsTerminal/WindowsTerminal.manifest b/src/cascadia/WindowsTerminal/WindowsTerminal.manifest index c89d68031..0f4759ba9 100644 --- a/src/cascadia/WindowsTerminal/WindowsTerminal.manifest +++ b/src/cascadia/WindowsTerminal/WindowsTerminal.manifest @@ -2,7 +2,10 @@ - + + + +