ci: update to Spell check to 0.0.17a (#9014)

### Plurals and paste tenses
In the past, plurals `foo`+`s` and past tenses `foo`+`ed` were
automatically tolerated. This turned out to be a bad design choice on my
part.

The basic example is that `potatos` would sometimes be treated as a
mistake and sometimes not (depending on the presence of `potato`).

You can see in this PR, that this logic resulted in `Applys` being
accepted as a word along with `AppContainered` -- there's nothing
intrinsically wrong w/ the latter, but unfortunately in order to screen
out the former, my shortcut just couldn't stick around. This means that
the `dictionary`/`expect` files will grow perhaps by a tiny bit, but as
you can see, not really by much.

This is also why `thereses` (a user) was accepted as a word in the past
(therese is in the base dictionary, so `therese` + `s` was acceptable).

### Pull requests

When GitHub initially introduced GitHub Actions, the event for
`pull_request` was created without enough permission for a tool like
this to work properly. I worked around that by using the `schedule`
event. In 2020, they introduced a replacement event
`pull_request_target` which has enough permission. This means that I can
stop relying on the `schedule` event.

### Miscellaneous

* I've folded together some `expect/` files since now is as good a time
  as any.
* I've included a hint about `excludes.txt` (I added a similar one for
  our primary repo recently, and it came up this week in
  `microsoft/terminal` -- @zadjii-msft)
* I've standardized on a default of `.github/actions/spelling` to make
  the out of the box experience easier for new adopters, so I'm applying
  that change here -- if you're attached to the old directory name,
  specifying it is still supported. -- note the directory rename may
  cause a merge conflict for people with open PRs and changes to the
  contents, this shouldn't be a big problem.

.github/actions/spell-check/expect/5757ec679b03a4240130c3c53766c91bbc5cd6a7.txt

@@ -1 +0,0 @@
-renamer

.github/actions/spell-check/expect/655f007265b351e140d20b3976792523ad689241.txt

@@ -1,7 +0,0 @@
-autogenerated
-CPPCORECHECK
-Debian
-filepath
-inplace
-KEYBDINPUT
-WINVER

.github/actions/spell-check/expect/a129ff14ec985d6b7bf09e296a831c955d41040b.txt

@@ -1,14 +0,0 @@
-checkboxes
-CSIDL
-csv
-horiz
-IDispatch
-inlines
-IWeb
-Progman
-reserialize
-SHANDLE
-SHGFP
-udk
-unfocus
-WClass

.github/actions/spelling/advice.txt

@@ -9,17 +9,19 @@ By default the command suggestion will generate a file named based on your commi
 
 If the listed items are:
 * ... **misspelled**, then please *correct* them instead of using the command.
-* ... *names*, please add them to `.github/actions/spell-check/dictionary/names.txt`.
-* ... APIs, you can add them to a file in `.github/actions/spell-check/dictionary/`.
-* ... just things you're using, please add them to an appropriate file in `.github/actions/spell-check/expect/`.
-* ... tokens you only need in one place and shouldn't *generally be used*, you can add an item in an appropriate file in `.github/actions/spell-check/patterns/`.
+* ... *names*, please add them to `.github/actions/spelling/dictionary/names.txt`.
+* ... APIs, you can add them to a file in `.github/actions/spelling/dictionary/`.
+* ... just things you're using, please add them to an appropriate file in `.github/actions/spelling/expect/`.
+* ... tokens you only need in one place and shouldn't *generally be used*, you can add an item in an appropriate file in `.github/actions/spelling/patterns/`.
 
 See the `README.md` in each directory for more information.
 
-:microscope: You can test your commits **without** *appending* to a PR by creating a new branch with that extra change and pushing it to your fork. The [:check-spelling](https://github.com/marketplace/actions/check-spelling) action will run in response to your **push** -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. :wink:
+:microscope: You can test your commits **without** *appending* to a PR by creating a new branch with that extra change and pushing it to your fork. The [check-spelling](https://github.com/marketplace/actions/check-spelling) action will run in response to your **push** -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. :wink:
 
+:clamp: If you see a bunch of garbage and it relates to a binary-ish string, please add a file path to the `.github/actions/spelling/excludes.txt` file instead of just accepting the garbage.
+
+File paths are Perl 5 Regular Expressions - you can [test](
+https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files.
+
+`^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md](https://github.com/microsoft/terminal/blob/main/README.md) (on whichever branch you're using).
 </details>
-
-#### :warning: Reviewers
-At present, the action that triggered this message will not show its :x: in this PR unless the branch is within this repository.
-Thus, you **should** make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

.github/actions/spelling/dictionary/dictionary.txt

@@ -116574,6 +116574,8 @@ Dowmetal
 Down
 down
 Downall
+downside
+downsides
 down-and-out
 down-and-outer
 down-at-heel
@@ -236348,6 +236350,7 @@ Maxama
 Maxantia
 Maxatawny
 Maxbass
+maxed
 Maxentia
 Maxey
 Maxfield
@@ -327070,6 +327073,7 @@ ptychopterygial
 ptychopterygium
 Ptychosperma
 p-type
+ptys
 ptysmagogue
 ptyxis
 PU
@@ -354226,6 +354230,7 @@ run-through
 runtier
 runtiest
 runtime
+runtimes
 runtiness
 runtish
 runtishly
@@ -420369,6 +420374,7 @@ tokening
 tokenism
 tokenisms
 tokenize
+tokenizes
 tokenless
 token-money
 tokens
@@ -432744,6 +432750,7 @@ uintjie
 UIP
 Uird
 Uirina
+UIs
 Uis
 UIT
 uit
@@ -459682,6 +459689,7 @@ versines
 versing
 version
 versional
+versioned
 versioner
 versionist
 versionize

.github/actions/spelling/dictionary/fonts.txt

@@ -1,5 +1,6 @@
 Consolas
 emoji
+emojis
 Extralight
 Gabriola
 Iosevka

.github/actions/spelling/dictionary/microsoft.txt

@@ -1,11 +1,19 @@
 ACLs
+ADMINS
 altform
+altforms
 appendwttlogging
 backplating
+bitmaps
+BOMs
+CPLs
 CPRs
 DACL
 DACLs
+diffs
+disposables
 dotnetfeed
+DTDs
 DWINRT
 enablewttlogging
 LKG

.github/actions/spelling/dictionary/names.txt

@@ -62,6 +62,7 @@ Somuah
 sonph
 sonpham
 stakx
+thereses
 Walisch
 Wirt
 Wojciech

.github/actions/spelling/excludes.txt

@@ -60,6 +60,6 @@ SUMS$
 ^src/renderer/wddmcon/WddmConRenderer\.
 ^src/terminal/parser/ft_fuzzer/VTCommandFuzzer\.cpp$
 ^src/tools/U8U16Test/(?:fr|ru|zh)\.txt$
-^\.github/actions/spell-check/
+^\.github/actions/spelling/
 ^\.gitignore$
 ^doc/reference/master-sequence-list.csv$

.github/actions/spelling/expect/expect.txt

@@ -1,4 +1,3 @@
-AAAAA
 AAAAAABBBBBBCCC
 AAAAABBBBBBBCCC
 AAAAABBBBBBCCC
@@ -110,6 +109,7 @@ aumid
 Authenticode
 AUTOBUDDY
 AUTOCHECKBOX
+autogenerated
 autohide
 AUTOHSCROLL
 automagically
@@ -251,6 +251,7 @@ charset
 CHARSETINFO
 chcp
 checkbox
+checkboxes
 chh
 Childitem
 chk
@@ -353,7 +354,6 @@ conprops
 conpropsp
 conpty
 conptylib
-consecteturadipiscingelit
 conserv
 consoleapi
 CONSOLECONTROL
@@ -393,6 +393,7 @@ CPINFOEX
 cplinfo
 cplusplus
 cpp
+CPPCORECHECK
 cppcorecheckrules
 cpprest
 cpprestsdk
@@ -415,6 +416,7 @@ csbi
 csbiex
 csharp
 CSHORT
+CSIDL
 csproj
 Csr
 csrmsg
@@ -427,6 +429,7 @@ cstdlib
 cstr
 cstring
 cstyle
+csv
 CSwitch
 CText
 ctime
@@ -507,6 +510,7 @@ DDESHARE
 DDevice
 DEADCHAR
 dealloc
+Debian
 debolden
 debounce
 DECALN
@@ -621,7 +625,6 @@ DLLVERSIONINFO
 DLOAD
 DLOOK
 dmp
-dnceng
 DOCTYPE
 docx
 DONTCARE
@@ -684,7 +687,7 @@ EHsc
 EJO
 EK
 ELEMENTNOTAVAILABLE
-Elems
+elems
 elif
 elseif
 emacs
@@ -765,6 +768,7 @@ FGHIJ
 fgidx
 FILEDESCRIPTION
 fileno
+filepath
 FILESUBTYPE
 FILESYSPATH
 filesystem
@@ -987,6 +991,7 @@ hmod
 hmodule
 hmon
 HMONITOR
+horiz
 HORZ
 hostable
 hostlib
@@ -1047,6 +1052,7 @@ IDesktop
 IDevice
 IDictionary
 IDISHWND
+IDispatch
 IDisposable
 idl
 idllib
@@ -1099,8 +1105,10 @@ INITMENU
 inkscape
 inl
 INLINEPREFIX
+inlines
 INotify
 inout
+inplace
 inproc
 Inputkeyinfo
 INPUTPROCESSORPROFILE
@@ -1163,6 +1171,7 @@ IValue
 IVector
 IWait
 iwch
+IWeb
 IWin
 IWindow
 IXaml
@@ -1191,6 +1200,7 @@ kcuu
 Kd
 kernelbase
 kernelbasestaging
+KEYBDINPUT
 keybinding
 keychord
 keydown
@@ -1271,7 +1281,6 @@ Loewen
 LOGFONT
 LOGFONTW
 logissue
-Loremipsumdolorsitamet
 lowercased
 loword
 lparam
@@ -1437,6 +1446,7 @@ MSGF
 MSGFILTER
 MSGFLG
 MSGMARKMODE
+MSGS
 MSGSCROLLMODE
 MSGSELECTMODE
 msiexec
@@ -1451,6 +1461,7 @@ mui
 Mul
 multiline
 munged
+munges
 mutex
 mutexes
 muxes
@@ -1465,7 +1476,6 @@ nameof
 namespace
 namespaced
 namestream
-Namquiseratal
 nano
 natvis
 nbsp
@@ -1583,11 +1593,11 @@ NTVDM
 ntverp
 NTWIN
 nuget
-Nullametrutrummetus
 nullness
 nullonfailure
 nullopt
 nullptr
+NULs
 numlock
 numpad
 NUMSCROLL
@@ -1821,6 +1831,8 @@ prioritization
 processenv
 processhost
 PROCESSINFOCLASS
+procs
+Progman
 proj
 PROPERTYID
 PROPERTYKEY
@@ -1955,7 +1967,8 @@ REGSTR
 reingest
 Relayout
 RELBINPATH
-Remoting
+remoting
+renamer
 renderengine
 rendersize
 reparent
@@ -1965,6 +1978,7 @@ Replymessage
 repositorypath
 rescap
 Resequence
+reserialize
 RESETCONTENT
 resheader
 resizable
@@ -1981,7 +1995,6 @@ rgba
 rgbi
 rgch
 rgci
-rgdx
 rgfae
 rgfte
 rgi
@@ -2124,6 +2137,7 @@ sfi
 SFINAE
 SFUI
 sgr
+SHANDLE
 SHCo
 shcore
 shellapi
@@ -2131,6 +2145,7 @@ shellex
 shellscalingapi
 SHFILEINFO
 SHGFI
+SHGFP
 SHIFTJIS
 Shl
 shlguid
@@ -2336,7 +2351,7 @@ texel
 TExpected
 textattribute
 TEXTATTRIBUTEID
-Textbox
+textbox
 textboxes
 textbuffer
 TEXTINCLUDE
@@ -2441,6 +2456,7 @@ ucdxml
 uch
 UCHAR
 ucs
+udk
 UDM
 uer
 uget
@@ -2463,6 +2479,7 @@ UNCPRIORITY
 undef
 Unescape
 unexpand
+Unfocus
 unhighlighting
 unhosted
 unicode
@@ -2532,7 +2549,7 @@ UVWXY
 UWA
 uwp
 uxtheme
-Vals
+vals
 Vanara
 vararg
 vbproj
@@ -2610,6 +2627,7 @@ wch
 wchar
 WCIA
 WCIW
+WClass
 wcout
 wcschr
 wcscmp
@@ -2704,6 +2722,7 @@ wintelnet
 winternl
 winuser
 winuserp
+WINVER
 wistd
 wixproj
 wline
@@ -2763,6 +2782,7 @@ WTEXT
 WTo
 wtof
 wtoi
+WTs
 wtw
 wtypes
 Wubi
@@ -2837,7 +2857,6 @@ Yw
 YWalk
 yx
 YZ
-yzx
 Zc
 ZCmd
 ZCtrl
@@ -2848,4 +2867,3 @@ zsh
 zu
 zxcvbnm
 zy
-

.github/actions/spelling/patterns/patterns.txt

@@ -16,7 +16,7 @@ Scro\&ll
  :\\windows\\syste\b
 TestUtils::VerifyExpectedString\(tb, L"[^"]+"
 (?:hostSm|mach)\.ProcessString\(L"[^"]+"
-\b([A-Za-z])\1{3,}\b
+\b([A-Za-z])\g{-1}{3,}\b
 0x[0-9A-Za-z]+
 Base64::s_(?:En|De)code\(L"[^"]+"
 VERIFY_ARE_EQUAL\(L"[^"]+"

.github/workflows/spelling.yml

@@ -1,9 +1,7 @@
 name: Spell checking
 on:
+  pull_request_target:
   push:
-  schedule:
-    # * is a special character in YAML so you have to quote this string
-    - cron: '15 * * * *'
 
 jobs:
   build:
@@ -12,9 +10,6 @@ jobs:
     steps:
     - uses: actions/checkout@v2.0.0
       with:
+        ref: ${{ github.event.pull_request.head.sha }}
         fetch-depth: 5
-    - uses: check-spelling/check-spelling@0.0.16-alpha
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        bucket: .github/actions
-        project: spell-check
+    - uses: check-spelling/check-spelling@0.0.17-alpha

src/cascadia/WindowsTerminal/IslandWindow.cpp

@@ -817,7 +817,7 @@ void IslandWindow::_BackupWindowSizes(const bool fCurrentIsInFullscreen)
 }
 
 // Method Description:
-// - Applys the appropriate window size for transitioning to/from fullscreen mode.
+// - Applies the appropriate window size for transitioning to/from fullscreen mode.
 // - Taken from conhost's Window::_ApplyWindowSize
 // Arguments:
 // - <none>

src/interactivity/onecore/ConsoleInputThread.cpp

@@ -89,7 +89,7 @@ DWORD WINAPI ConsoleInputThreadProcOneCore(LPVOID /*lpParam*/)
     {
         // If we get an access denied and couldn't connect to the coniosrv in CSRSS.exe.
         // that's OK. We're likely inside an AppContainer in a TAEF /runas:uap test.
-        // We don't want AppContainered things to have access to the hardware devices directly
+        // We don't want things in an AppContainer to have access to the hardware devices directly
         // like coniosrv in CSRSS offers, so we "succeeded" and will let the IO thread know it
         // can continue.
         if (STATUS_ACCESS_DENIED == Status)