From 59c193c22a3121ad5fb2d41158a71fe2711d99cf Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Wed, 10 Nov 2021 15:54:32 -0600 Subject: [PATCH] okay, so it's just vintage(100)+cleartype that doesn't work. Everything else gracefully falls back to grayscale --- src/cascadia/TerminalControl/ControlCore.cpp | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/cascadia/TerminalControl/ControlCore.cpp b/src/cascadia/TerminalControl/ControlCore.cpp index 3c65ef6db..d912795f6 100644 --- a/src/cascadia/TerminalControl/ControlCore.cpp +++ b/src/cascadia/TerminalControl/ControlCore.cpp @@ -439,6 +439,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation 0.0, 1.0); + auto lock = _terminal->LockForWriting(); // Update our runtime opacity value Opacity(newOpacity); @@ -450,18 +451,17 @@ namespace winrt::Microsoft::Terminal::Control::implementation // is what the Terminal did prior to 1.12. if (!IsVintageOpacityAvailable()) { - const auto oldUseAcrylic{ UseAcrylic() }; + // const auto oldUseAcrylic{ UseAcrylic() }; _runtimeUseAcrylic = newOpacity < 1.0; - // If they've changed the value of UseAcrylic, then update the - // renderer as well. - if (oldUseAcrylic != UseAcrylic() && _renderEngine) - { - // GH#5098: Inform the engine of the new opacity of the default - // text background. - auto lock = _terminal->LockForWriting(); - _renderEngine->SetDefaultTextBackgroundOpacity(_correctForTransparency()); - } + // // If they've changed the value of UseAcrylic, then update the + // // renderer as well. + // if (oldUseAcrylic != UseAcrylic() && _renderEngine) + // { + // // GH#5098: Inform the engine of the new opacity of the default + // // text background. + // } } + _renderEngine->SetDefaultTextBackgroundOpacity(_correctForTransparency()); auto eventArgs = winrt::make_self(newOpacity); _TransparencyChangedHandlers(*this, *eventArgs);